[U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured

[Lukasz Majewski <lukma@denx.de>]

Hi Eugen,

Thanks for (re-)bringing the One wire support to u-boot.

> Add a sandbox eeprom on the bus as a device, if sandbox driver is
> configured.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  drivers/w1/w1-uclass.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c
> index cfddda3..e58c1ca 100644
> --- a/drivers/w1/w1-uclass.c
> +++ b/drivers/w1/w1-uclass.c
> @@ -142,6 +142,11 @@ static int w1_enumerate(struct udevice *bus)
>  		}
>  	}
>  
> +#ifdef CONFIG_W1_EEPROM_SANDBOX
> +	/* before we are finished, add a sandbox device if we can */
> +	w1_new_device(bus, W1_FAMILY_EEP_SANDBOX);
> +#endif

IMHO we shouldn't mix the sandbox code with production (on boards) code.

Maybe Simon (+CCed) could provide some more input here?

> +
>  	return 0;
>  }
>  




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180720/e2748551/attachment.sig>