From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/17] fs: add mkdir interface
Date: Tue, 24 Jul 2018 10:45:58 +0900 [thread overview]
Message-ID: <20180724014557.GX11258@linaro.org> (raw)
In-Reply-To: <20180723235658.GC11755@bill-the-cat>
On Mon, Jul 23, 2018 at 07:56:58PM -0400, Tom Rini wrote:
> On Mon, Jul 23, 2018 at 05:48:13PM -0600, Simon Glass wrote:
> > Hi,
> >
> > On 20 July 2018 at 11:35, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > > On 07/20/2018 04:57 AM, AKASHI Takahiro wrote:
> > >> "mkdir" interface is added to file operations.
> > >> This is a preparatory change as mkdir support for FAT file system
> > >> will be added in next patch.
> > >>
> > >> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > >> ---
> > >> fs/fs.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > >> include/fs.h | 10 ++++++++++
> > >> 2 files changed, 55 insertions(+)
> > >>
> >
> > We need to get a proper fs test in place before we add any more stuff.
>
> Agreed that we need more tests as part of this series.
Is this a new standard rule for new features?
Just kidding, but testing was definitely one of my concerns partly
because fs-test.sh is anyhow in an old fashion and partly because
I can't find any criteria for test coverage:
- white-box test or black-box test
- coverage for corner (or edge) cases
- some sort of stress test, etc.
> > Does someone waent to try converting fs-test.sh to pytest in test/py/tests ?
>
> I thought there was at least a first pass at that?
Well, I don't see any file system related scripts under test/py/tests.
Please advise me.
Thanks,
-Takahiro AKASHI
> --
> Tom
next prev parent reply other threads:[~2018-07-24 1:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 2:57 [U-Boot] [PATCH 00/17] fs: fat: extend FAT write operations AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 01/17] fs: fat: extend get_fs_info() for write use AKASHI Takahiro
2018-07-20 18:06 ` Heinrich Schuchardt
2018-07-22 7:43 ` Heinrich Schuchardt
2018-07-20 2:57 ` [U-Boot] [PATCH 02/17] fs: fat: handle "." and ".." of root dir correctly with fat_itr_resolve() AKASHI Takahiro
2018-07-20 18:09 ` Heinrich Schuchardt
2018-07-23 7:55 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 03/17] fs: fat: make directory iterator global for write use AKASHI Takahiro
2018-07-20 18:02 ` Heinrich Schuchardt
2018-07-23 8:06 ` AKASHI Takahiro
2018-07-23 8:18 ` AKASHI Takahiro
2018-08-11 13:34 ` Heinrich Schuchardt
2018-08-20 4:45 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 04/17] fs: fat: assure iterator's ->dent belongs to ->clust AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 05/17] fs: fat: check and normailze file name AKASHI Takahiro
2018-07-31 4:31 ` Heinrich Schuchardt
2018-07-20 2:57 ` [U-Boot] [PATCH 06/17] fs: fat: write returns error code instead of -1 AKASHI Takahiro
2018-07-20 17:55 ` Heinrich Schuchardt
2018-07-23 8:32 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 07/17] fs: fat: support write with sub-directory path AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 08/17] fs: fat: refactor write interface for a file offset AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 09/17] fs: fat: support write with non-zero offset AKASHI Takahiro
2018-07-20 17:46 ` Heinrich Schuchardt
2018-07-23 8:41 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 10/17] cmd: fat: add offset parameter to fatwrite AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 11/17] fs: add mkdir interface AKASHI Takahiro
2018-07-20 17:35 ` Heinrich Schuchardt
2018-07-23 23:48 ` Simon Glass
2018-07-23 23:56 ` Tom Rini
2018-07-24 1:45 ` AKASHI Takahiro [this message]
2018-07-25 2:45 ` Simon Glass
2018-07-24 0:56 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 12/17] fs: fat: remember the starting cluster number of directory AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 13/17] fs: fat: support mkdir AKASHI Takahiro
2018-07-20 17:14 ` Heinrich Schuchardt
2018-07-24 2:01 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 14/17] cmd: fat: add fatmkdir command AKASHI Takahiro
2018-07-20 17:09 ` Heinrich Schuchardt
2018-07-24 2:07 ` AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 15/17] efi_loader: file: support creating a directory AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 16/17] efi_loader: implement a pseudo "file delete" AKASHI Takahiro
2018-07-20 2:57 ` [U-Boot] [PATCH 17/17] fs-test: fix false positive error at Test Case 12 AKASHI Takahiro
2018-07-29 7:02 ` Heinrich Schuchardt
2018-07-31 7:55 ` AKASHI Takahiro
2018-07-20 9:48 ` [U-Boot] [PATCH 00/17] fs: fat: extend FAT write operations Heinrich Schuchardt
2018-07-22 6:44 ` Heinrich Schuchardt
2018-07-23 7:35 ` AKASHI Takahiro
2018-07-23 14:46 ` Tom Rini
2018-08-06 22:34 ` Heinrich Schuchardt
2018-08-07 5:38 ` AKASHI Takahiro
2018-08-07 5:52 ` AKASHI Takahiro
2018-08-07 5:53 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724014557.GX11258@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox