From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Tue, 24 Jul 2018 10:45:58 +0900 Subject: [U-Boot] [PATCH 11/17] fs: add mkdir interface In-Reply-To: <20180723235658.GC11755@bill-the-cat> References: <20180720025723.6736-1-takahiro.akashi@linaro.org> <20180720025723.6736-12-takahiro.akashi@linaro.org> <20180723235658.GC11755@bill-the-cat> Message-ID: <20180724014557.GX11258@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jul 23, 2018 at 07:56:58PM -0400, Tom Rini wrote: > On Mon, Jul 23, 2018 at 05:48:13PM -0600, Simon Glass wrote: > > Hi, > > > > On 20 July 2018 at 11:35, Heinrich Schuchardt wrote: > > > On 07/20/2018 04:57 AM, AKASHI Takahiro wrote: > > >> "mkdir" interface is added to file operations. > > >> This is a preparatory change as mkdir support for FAT file system > > >> will be added in next patch. > > >> > > >> Signed-off-by: AKASHI Takahiro > > >> --- > > >> fs/fs.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > > >> include/fs.h | 10 ++++++++++ > > >> 2 files changed, 55 insertions(+) > > >> > > > > We need to get a proper fs test in place before we add any more stuff. > > Agreed that we need more tests as part of this series. Is this a new standard rule for new features? Just kidding, but testing was definitely one of my concerns partly because fs-test.sh is anyhow in an old fashion and partly because I can't find any criteria for test coverage: - white-box test or black-box test - coverage for corner (or edge) cases - some sort of stress test, etc. > > Does someone waent to try converting fs-test.sh to pytest in test/py/tests ? > > I thought there was at least a first pass at that? Well, I don't see any file system related scripts under test/py/tests. Please advise me. Thanks, -Takahiro AKASHI > -- > Tom