From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured
Date: Tue, 24 Jul 2018 08:58:28 +0200 [thread overview]
Message-ID: <20180724065828.nsbfkitstqg53h4c@flea> (raw)
In-Reply-To: <CAPnjgZ3L6dXr+xxu62E7Rmwsp2YH1zgk+uiYdzhNHXtfoo62Ww@mail.gmail.com>
On Mon, Jul 23, 2018 at 05:48:25PM -0600, Simon Glass wrote:
> Hi,
>
> On 20 July 2018 at 08:01, Lukasz Majewski <lukma@denx.de> wrote:
> > Hi Eugen,
> >
> > Thanks for (re-)bringing the One wire support to u-boot.
> >
> >> Add a sandbox eeprom on the bus as a device, if sandbox driver is
> >> configured.
> >>
> >> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> >> ---
> >> drivers/w1/w1-uclass.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/drivers/w1/w1-uclass.c b/drivers/w1/w1-uclass.c
> >> index cfddda3..e58c1ca 100644
> >> --- a/drivers/w1/w1-uclass.c
> >> +++ b/drivers/w1/w1-uclass.c
> >> @@ -142,6 +142,11 @@ static int w1_enumerate(struct udevice *bus)
> >> }
> >> }
> >>
> >> +#ifdef CONFIG_W1_EEPROM_SANDBOX
> >> + /* before we are finished, add a sandbox device if we can */
> >> + w1_new_device(bus, W1_FAMILY_EEP_SANDBOX);
> >> +#endif
> >
> > IMHO we shouldn't mix the sandbox code with production (on boards) code.
> >
> > Maybe Simon (+CCed) could provide some more input here?
>
> I have not seen this series. But new devices should be created
> automatically based on them being in the device tree. So you should
> just be able to add them there.
1-Wire is discoverable, so there's no device nodes in the DT.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180724/33f3bc6c/attachment.sig>
next prev parent reply other threads:[~2018-07-24 6:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 9:57 [U-Boot] [PATCH 00/20] Add support for 1wire protocol and 1wire eeproms Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 01/20] w1: Add 1-Wire uclass Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 02/20] w1: Add 1-Wire gpio driver Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 03/20] dt-bindings: W1: w1-gpio: added bindings for w1-gpio Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 04/20] W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs Eugen Hristev
2018-07-20 14:28 ` Maxime Ripard
2018-07-30 8:54 ` Eugen Hristev
2018-07-31 2:06 ` Tom Rini
2018-08-02 16:56 ` Simon Glass
2018-07-19 9:57 ` [U-Boot] [PATCH 05/20] W1-EEPROM: add support for Maxim DS24 eeprom families Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 06/20] W1-EEPROM: add sandbox driver Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 07/20] w1: add command for onewire protocol Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 08/20] pinctrl: sandbox: add gpio onewire w1 group Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 09/20] sandbox: DTS: w1: add node for one wire interface on GPIO Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 10/20] configs: sandbox: add onewire w1 and sandbox eeprom Eugen Hristev
2018-07-19 9:57 ` [U-Boot] [PATCH 11/20] w1: enumerate sandbox driver if configured Eugen Hristev
2018-07-20 14:01 ` Lukasz Majewski
2018-07-23 23:48 ` Simon Glass
2018-07-24 6:58 ` Maxime Ripard [this message]
2018-07-24 15:28 ` Simon Glass
2018-07-25 9:15 ` Maxime Ripard
2018-07-19 9:58 ` [U-Boot] [PATCH 12/20] configs: sama5d2_xplained: add onewire and eeprom drivers Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 13/20] configs: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 14/20] board: atmel: add support for pda detection Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 15/20] board: sama5d2_xplained: add pda detect call at init time Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 16/20] board: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 17/20] configs: sama5d2_xplained: add fdt overlay support Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 18/20] configs: sama5d3_xplained: " Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 19/20] ARM: dts: at91: sama5d2_xplained: add onewire connector for LCD eeprom Eugen Hristev
2018-07-19 9:58 ` [U-Boot] [PATCH 20/20] ARM: dts: at91: sama5d3_xplained: " Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724065828.nsbfkitstqg53h4c@flea \
--to=maxime.ripard@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox