[U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect

[U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect

[Heinrich Schuchardt]

Assigning a parameter which is not used afterwards has not effect.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/bios_emulator/atibios.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bios_emulator/atibios.c b/drivers/bios_emulator/atibios.c
index 2d5b5dc562..545ccd6f1e 100644
--- a/drivers/bios_emulator/atibios.c
+++ b/drivers/bios_emulator/atibios.c
@@ -602,7 +602,6 @@ int biosemu_run(pci_dev_t pcidev, uchar *bios_rom, int bios_len,
 		    (ulong)(vga_info->BIOSImage) != 0xc0000)
 			free(vga_info->BIOSImage);
 		free(vga_info);
-		vga_info = NULL;
 	}
 
 	return 0;
-- 
2.16.2

[U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect

[Simon Glass]

On 18 March 2018 at 04:01, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Assigning a parameter which is not used afterwards has not effect.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/bios_emulator/atibios.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

It is probably just trying to indicate that the value is no-longer valid.

[U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect

[Heinrich Schuchardt]

On 03/19/2018 06:59 PM, Simon Glass wrote:
> On 18 March 2018 at 04:01, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>> Assigning a parameter which is not used afterwards has not effect.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  drivers/bios_emulator/atibios.c | 1 -
>>  1 file changed, 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> It is probably just trying to indicate that the value is no-longer valid.
> 

Hello Tom,

https://patchwork.ozlabs.org/patch/887353/
https://lists.denx.de/pipermail/u-boot/2018-March/323086.html

Another patch that fell into oblivion. Could you, please, merge it.

Best regards

Heinrich

[U-Boot] [U-Boot, 1/1] bios_emulator: remove assignment without effect

[Tom Rini]

On Sun, Mar 18, 2018 at 11:01:23AM +0100, Heinrich Schuchardt wrote:

> Assigning a parameter which is not used afterwards has not effect.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180724/6be1b1e9/attachment.sig>