* [U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect
@ 2018-03-18 10:01 Heinrich Schuchardt
2018-03-19 17:59 ` Simon Glass
2018-07-24 12:37 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 2 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2018-03-18 10:01 UTC (permalink / raw)
To: u-boot
Assigning a parameter which is not used afterwards has not effect.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/bios_emulator/atibios.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bios_emulator/atibios.c b/drivers/bios_emulator/atibios.c
index 2d5b5dc562..545ccd6f1e 100644
--- a/drivers/bios_emulator/atibios.c
+++ b/drivers/bios_emulator/atibios.c
@@ -602,7 +602,6 @@ int biosemu_run(pci_dev_t pcidev, uchar *bios_rom, int bios_len,
(ulong)(vga_info->BIOSImage) != 0xc0000)
free(vga_info->BIOSImage);
free(vga_info);
- vga_info = NULL;
}
return 0;
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect
2018-03-18 10:01 [U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect Heinrich Schuchardt
@ 2018-03-19 17:59 ` Simon Glass
2018-07-22 9:59 ` Heinrich Schuchardt
2018-07-24 12:37 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2018-03-19 17:59 UTC (permalink / raw)
To: u-boot
On 18 March 2018 at 04:01, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Assigning a parameter which is not used afterwards has not effect.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/bios_emulator/atibios.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
It is probably just trying to indicate that the value is no-longer valid.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, 1/1] bios_emulator: remove assignment without effect
2018-03-18 10:01 [U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect Heinrich Schuchardt
2018-03-19 17:59 ` Simon Glass
@ 2018-07-24 12:37 ` Tom Rini
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2018-07-24 12:37 UTC (permalink / raw)
To: u-boot
On Sun, Mar 18, 2018 at 11:01:23AM +0100, Heinrich Schuchardt wrote:
> Assigning a parameter which is not used afterwards has not effect.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180724/6be1b1e9/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-24 12:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-18 10:01 [U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect Heinrich Schuchardt
2018-03-19 17:59 ` Simon Glass
2018-07-22 9:59 ` Heinrich Schuchardt
2018-07-24 12:37 ` [U-Boot] [U-Boot, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox