From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] hashtable: Fix length calculation in hexport_r
Date: Thu, 26 Jul 2018 15:54:26 -0400 [thread overview]
Message-ID: <20180726195426.GK7590@bill-the-cat> (raw)
In-Reply-To: <1531851938-12107-1-git-send-email-zubair@resin.io>
On Tue, Jul 17, 2018 at 07:25:38PM +0100, Zubair Lutfullah Kakakhel wrote:
> The length returned by hexport_r has a few redundant characters.
> This appears as NULL characters at the end so seems harmless.
>
> Remove the surplus counts in two places
>
> totlen += strlen(ep->key) + 2;
> I'm guessing the +2 here is for = and sep char. But there is another
> totlen += 2; line that does that.
>
> size = totletn + 1;
> Doesn't make sense and isn't justified with any comment.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <zubair@resin.io>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180726/8893f84e/attachment.sig>
next prev parent reply other threads:[~2018-07-26 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 18:25 [U-Boot] [PATCH] hashtable: Fix length calculation in hexport_r Zubair Lutfullah Kakakhel
2018-07-26 19:54 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-14 9:42 [U-Boot] [PATCH] hashtable: fix " AKASHI Takahiro
2018-12-17 12:10 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726195426.GK7590@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox