[U-Boot] Pull request: u-boot-net.git master

Tom Rini
2018-01-15T18:22:44Z

On Mon, Jan 15, 2018 at 12:15:24PM -0600, Joe Hershberger wrote:
> On Mon, Jan 15, 2018 at 12:13 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Mon, Jan 15, 2018 at 12:10:17PM -0600, Joe Hershberger wrote:
> >> Hi Tom,
> >>
> >> On Tue, Jan 9, 2018 at 12:06 PM, Tom Rini <trini@konsulko.com> wrote:
> >> > On Wed, Jan 03, 2018 at 03:32:31PM -0600, Joe Hershberger wrote:
> >> >
> >> >> Hi Tom,
> >> >>
> >> >> The following changes since commit 1314bd1192b4c67d28bdae7eee639588e88090cd:
> >> >>
> >> >> boards: amlogic: khadas-vim: Typo fixup (2018-01-02 07:57:34 -0500)
> >> >>
> >> >> are available in the git repository at:
> >> >>
> >> >> git://git.denx.de/u-boot-net.git master
> >> >>
> >> >> for you to fetch changes up to c925860a49905177e6c355cacf7a25b4c617af6b:
> >> >>
> >> >> phy: atheros: set auto-negotiation for AR8021 (2018-01-03 11:06:31 -0600)
> >> >>
> >> >>
> >> >> All board pass compile tests on Travis: https://travis-ci.org/jhershbe/u-boot/builds/324666118
> >> >>
> >> >>
> >> >
> >> > NAK. The following change (via git bisect'ing):
> >> > commit 003eaf15a043cf6f9c21d757a93610575d9b7ba2
> >> > Author: Joe Hershberger <joe.hershberger@ni.com>
> >> > Date: Wed Aug 30 17:42:26 2017 -0500
> >> >
> >> > net: Correct size of NFS buffers
> >> >
> >> > Reported-by: Coverity (CID: 152888)
> >> > Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> >> > is breaking NFS for me on my am335x_evm:
> >> > 12:58:46 ----------------------------- Captured stdout call -----------------------------
> >> > 12:58:46 => nfs 80400000 /tftpboot/1MiBtest.bin
> >> > 12:58:46 link up on port 0, speed 1000, full duplex
> >> > 12:58:46 #################################################################
> >> > 12:58:46 #################################################################
> >> > 12:58:46 #################################################################
> >> > 12:58:46 ##########
> >> > 12:58:46 done
> >> > 12:58:46 Bytes transferred = 1048576 (100000 hex)
> >> > 12:58:46 => => crc32 80400000 $filesize
> >> > 12:58:46 crc32 for 80400000 ... 804fffff ==> 1edf15ed
> >> > 12:58:46 =>
> >> > 12:58:46 =============== 1 failed, 78 passed, 25 skipped in 32.80 seconds ===============
> >> >
> >> > I can't point to any SW-only tests that show this as they're passing. Any ideas?
> >> > Thanks!
> >>
> >> I can't see any obvious reason for the error, so it will need
> >> debugging. I've sent a new PR with this dropped for now. I'll look
> >> into fixing it for real when I can get to it.
> >>
> >> Are these tests you're running possible to include in travis?
> >
> > So, that's part of the problem. These are the standard tests we do run
> > in Travis, in QEMU, and they pass. It's only on real hardware where it
> > fails.
>
> OK, good to know. Any particular arch? or just all that you have tried?

It honestly failed on the first real board I tried it on, so I didn't
try others. I suppose since I have a faster local box than I used to, I
might look at turning my real HW tests in jenkins into a matrix rather
than a single job. It failed on am335x_evm which is ARM.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180115/d604a5b6/attachment.sig>