[U-Boot] [PATCH] Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined"

[U-Boot] [PATCH] Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined"

[Ramon Fried]

This reverts commit 5e5745465c94605720295fab942eacbdd215db90.

The reverted commit didn't support the scenario where there are less
DRAM banks in U-Boot than in Linux.
Also, it didn't introduce any new functionality, only limitaion.
User could just increase MEMORY_BANKS_MAX if it's too small.
---
 common/fdt_support.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/common/fdt_support.c b/common/fdt_support.c
index 812eca8173..26f50a94ee 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -409,11 +409,7 @@ static int fdt_pack_reg(const void *fdt, void *buf, u64 *address, u64 *size,
 	return p - (char *)buf;
 }
 
-#ifdef CONFIG_NR_DRAM_BANKS
-#define MEMORY_BANKS_MAX CONFIG_NR_DRAM_BANKS
-#else
 #define MEMORY_BANKS_MAX 4
-#endif
 int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
 {
 	int err, nodeoffset;
-- 
2.18.0

[U-Boot] [PATCH] Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined"

[Simon Glass]

On 21 July 2018 at 23:12, Ramon Fried <ramon.fried@gmail.com> wrote:
> This reverts commit 5e5745465c94605720295fab942eacbdd215db90.
>
> The reverted commit didn't support the scenario where there are less
> DRAM banks in U-Boot than in Linux.
> Also, it didn't introduce any new functionality, only limitaion.
> User could just increase MEMORY_BANKS_MAX if it's too small.
> ---
>  common/fdt_support.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined"

[Tom Rini]

On Sun, Jul 22, 2018 at 08:12:14AM +0300, Ramon Fried wrote:

> This reverts commit 5e5745465c94605720295fab942eacbdd215db90.
> 
> The reverted commit didn't support the scenario where there are less
> DRAM banks in U-Boot than in Linux.
> Also, it didn't introduce any new functionality, only limitaion.
> User could just increase MEMORY_BANKS_MAX if it's too small.
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180730/62ef45a9/attachment.sig>