public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v5] u-boot: remove driver lookup loop from env_save()
Date: Mon, 30 Jul 2018 16:01:42 -0400	[thread overview]
Message-ID: <20180730200142.GU32145@bill-the-cat> (raw)
In-Reply-To: <1532332867-6180-1-git-send-email-nicholas.faustini@azcomtech.com>

On Mon, Jul 23, 2018 at 10:01:07AM +0200, Nicholas Faustini wrote:

> When called with ENVOP_SAVE, env_get_location() only returns the
> gd->env_load_location variable without actually checking for
> the environment location and priority.
> 
> This behaviour causes env_save() to fall into an infinite loop when
> the low-level drv->save() call fails.
> 
> The env_save() function should not loop through the environment
> location list but it should save the environment into the location
> stored in gd->env_load_location by the last env_load() call.
> 
> Signed-off-by: Nicholas Faustini <nicholas.faustini@azcomtech.com>
> Reviewed-by: Simon Goldschmidt <sgoldschmidt@de.pepperl-fuchs.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180730/73340dad/attachment.sig>

      parent reply	other threads:[~2018-07-30 20:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23  8:01 [U-Boot] [PATCH v5] u-boot: remove driver lookup loop from env_save() Nicholas Faustini
2018-07-26  5:16 ` Simon Goldschmidt
2018-07-26 14:02   ` Maxime Ripard
2018-07-26 20:16     ` Goldschmidt Simon
2018-07-27  0:29       ` Tom Rini
2018-07-27  7:59         ` Nicholas
2018-07-30 20:01 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730200142.GU32145@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox