* [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
@ 2018-07-24 6:27 Peng Fan
2018-07-24 23:41 ` Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peng Fan @ 2018-07-24 6:27 UTC (permalink / raw)
To: u-boot
To system which has kconfiglib installed, genboardscfg will
use system kconfiglib, we need it use U-Boot owned version,
so move the buildman path to first.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
tools/genboardscfg.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py
index 0648472af0..e9bbd15e15 100755
--- a/tools/genboardscfg.py
+++ b/tools/genboardscfg.py
@@ -24,7 +24,7 @@ import sys
import tempfile
import time
-sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
+sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman'))
import kconfiglib
### constant variables ###
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
2018-07-24 6:27 [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first Peng Fan
@ 2018-07-24 23:41 ` Masahiro Yamada
2018-07-25 2:45 ` Simon Glass
2018-07-30 20:02 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2018-07-24 23:41 UTC (permalink / raw)
To: u-boot
2018-07-24 15:27 GMT+09:00 Peng Fan <peng.fan@nxp.com>:
> To system which has kconfiglib installed, genboardscfg will
> use system kconfiglib, we need it use U-Boot owned version,
> so move the buildman path to first.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> tools/genboardscfg.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py
> index 0648472af0..e9bbd15e15 100755
> --- a/tools/genboardscfg.py
> +++ b/tools/genboardscfg.py
> @@ -24,7 +24,7 @@ import sys
> import tempfile
> import time
>
> -sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
> +sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman'))
> import kconfiglib
>
> ### constant variables ###
> --
> 2.14.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
2018-07-24 6:27 [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first Peng Fan
2018-07-24 23:41 ` Masahiro Yamada
@ 2018-07-25 2:45 ` Simon Glass
2018-07-25 2:51 ` Peng Fan
2018-07-30 20:02 ` [U-Boot] " Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2018-07-25 2:45 UTC (permalink / raw)
To: u-boot
Hi Peng,
On 24 July 2018 at 00:27, Peng Fan <peng.fan@nxp.com> wrote:
> To system which has kconfiglib installed, genboardscfg will
> use system kconfiglib, we need it use U-Boot owned version,
> so move the buildman path to first.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> tools/genboardscfg.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py
> index 0648472af0..e9bbd15e15 100755
> --- a/tools/genboardscfg.py
> +++ b/tools/genboardscfg.py
> @@ -24,7 +24,7 @@ import sys
> import tempfile
> import time
>
> -sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
> +sys.path.insert(1, os.path.join(os.path.dirname(__file__), 'buildman'))
How come you insert this second in the list rather than first? If that
is deliberate, can you please add a comment?
> import kconfiglib
>
> ### constant variables ###
> --
> 2.14.1
>
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
2018-07-25 2:45 ` Simon Glass
@ 2018-07-25 2:51 ` Peng Fan
2018-07-25 3:12 ` Simon Glass
0 siblings, 1 reply; 6+ messages in thread
From: Peng Fan @ 2018-07-25 2:51 UTC (permalink / raw)
To: u-boot
Hi Simon,
> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2018年7月25日 10:45
> To: Peng Fan <peng.fan@nxp.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; dl-linux-imx
> <linux-imx@nxp.com>; Masahiro Yamada <yamada.m@jp.panasonic.com>;
> Tom Rini <trini@konsulko.com>
> Subject: Re: [PATCH] tools: genboardscfg: move buildman path to first
>
> Hi Peng,
>
> On 24 July 2018 at 00:27, Peng Fan <peng.fan@nxp.com> wrote:
> > To system which has kconfiglib installed, genboardscfg will use system
> > kconfiglib, we need it use U-Boot owned version, so move the buildman
> > path to first.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Tom Rini <trini@konsulko.com>
> > ---
> > tools/genboardscfg.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index
> > 0648472af0..e9bbd15e15 100755
> > --- a/tools/genboardscfg.py
> > +++ b/tools/genboardscfg.py
> > @@ -24,7 +24,7 @@ import sys
> > import tempfile
> > import time
> >
> > -sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
> > +sys.path.insert(1, os.path.join(os.path.dirname(__file__),
> > +'buildman'))
>
> How come you insert this second in the list rather than first? If that is deliberate,
> can you please add a comment?
Do you mean I need to use `sys.path.insert(0, os.path.join(os.path.dirname(__file__), +'buildman'))`?
I print my sys.path, the first is '', So I follow other code in uboot, and use '1' here.
Thanks,
Peng.
>
> > import kconfiglib
> >
> > ### constant variables ###
> > --
> > 2.14.1
> >
>
> Regards,
> Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first
2018-07-25 2:51 ` Peng Fan
@ 2018-07-25 3:12 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2018-07-25 3:12 UTC (permalink / raw)
To: u-boot
Hi Peng,
On 24 July 2018 at 19:51, Peng Fan <peng.fan@nxp.com> wrote:
> Hi Simon,
>
>> -----Original Message-----
>> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: 2018年7月25日 10:45
>> To: Peng Fan <peng.fan@nxp.com>
>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; dl-linux-imx
>> <linux-imx@nxp.com>; Masahiro Yamada <yamada.m@jp.panasonic.com>;
>> Tom Rini <trini@konsulko.com>
>> Subject: Re: [PATCH] tools: genboardscfg: move buildman path to first
>>
>> Hi Peng,
>>
>> On 24 July 2018 at 00:27, Peng Fan <peng.fan@nxp.com> wrote:
>> > To system which has kconfiglib installed, genboardscfg will use system
>> > kconfiglib, we need it use U-Boot owned version, so move the buildman
>> > path to first.
>> >
>> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> > Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> > Cc: Simon Glass <sjg@chromium.org>
>> > Cc: Tom Rini <trini@konsulko.com>
>> > ---
>> > tools/genboardscfg.py | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index
>> > 0648472af0..e9bbd15e15 100755
>> > --- a/tools/genboardscfg.py
>> > +++ b/tools/genboardscfg.py
>> > @@ -24,7 +24,7 @@ import sys
>> > import tempfile
>> > import time
>> >
>> > -sys.path.append(os.path.join(os.path.dirname(__file__), 'buildman'))
>> > +sys.path.insert(1, os.path.join(os.path.dirname(__file__),
>> > +'buildman'))
>>
>> How come you insert this second in the list rather than first? If that is deliberate,
>> can you please add a comment?
>
> Do you mean I need to use `sys.path.insert(0, os.path.join(os.path.dirname(__file__), +'buildman'))`?
>
> I print my sys.path, the first is '', So I follow other code in uboot, and use '1' here.
OK I see, fair enough.
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] tools: genboardscfg: move buildman path to first
2018-07-24 6:27 [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first Peng Fan
2018-07-24 23:41 ` Masahiro Yamada
2018-07-25 2:45 ` Simon Glass
@ 2018-07-30 20:02 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2018-07-30 20:02 UTC (permalink / raw)
To: u-boot
On Tue, Jul 24, 2018 at 02:27:18PM +0800, Peng Fan wrote:
> To system which has kconfiglib installed, genboardscfg will
> use system kconfiglib, we need it use U-Boot owned version,
> so move the buildman path to first.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180730/0ee97bf5/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-30 20:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 6:27 [U-Boot] [PATCH] tools: genboardscfg: move buildman path to first Peng Fan
2018-07-24 23:41 ` Masahiro Yamada
2018-07-25 2:45 ` Simon Glass
2018-07-25 2:51 ` Peng Fan
2018-07-25 3:12 ` Simon Glass
2018-07-30 20:02 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox