From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 00/27] SPI-NAND support
Date: Tue, 31 Jul 2018 09:37:20 +0200 [thread overview]
Message-ID: <20180731093720.2b3d4db2@xps13> (raw)
In-Reply-To: <ed877c8d-a17d-423a-b7d4-7cad67e20ced@denx.de>
Hi Jagan,
Stefan Roese <sr@denx.de> wrote on Tue, 31 Jul 2018 07:50:54 +0200:
> Hi Jagan,
>
> On 31.07.2018 07:36, Jagan Teki wrote:
>
> <snip>
>
> >>>> Acked--by: Jagan Teki <jagan@openedev.com>
> >>>>
> >>>
> >>> Thanks!
> >>>
> >>>> Can you rebase on master and send the needed patches or whole? Look
> >>>> like some changes been added in drivers/mtd/nand/Kconfig
> >>>
> >>>
> >>> I'll wait a bit for Stefan review also and I think I missed something
> >>> in mtdparts: old partitions are not freed when creating new ones.
> > > Is this resolved with v5?
Absolutely not, but I will fix it in a next series during the
stabilization cycle. Maybe I will rework a bit mtdparts too, to trash
the thin layer that handles the partitions to use in a much more
consistent way the MTD core.
> > >>
> >> I'm back from vacation and am starting to work on this SPI NAND
> >> support again. Right now, I'm facing a problem with 32 Bytes
> >> missing when written to NAND and read back. Most likely a problem
> >> with my SPI driver which supports a maximum of 32 Bytes per SPI
> >> message (I'm using adjust_op_size() to adjust the max xfer size).
> > > Is it with kirkwood?
>
> No. Its with a new platform I'm currently working on (MediaTek
> MT7688 MIPS) - custom board. The platform and board port will be
> posted in a few days / weeks (once its ready).
>
> >> As for waiting for my review comments, I would suggest to pull
> >> this patchset (once updated onto TOT) soon, as the merge window
> >> closes just today. We can fix issues later in this release cycle.
> >> Otherwise we need to postpone this series to the next release, which
> >> is of course also on option.
> > > If the issue is generic and it changed the current behavior on mtd or
> > any other related areas, it's better to hold.
>
> AFAICT its not generic. The SPI NAND seems to be working for Miquel
> and its a new infrastructure. So chances for breaking an existing
> board / platform are pretty low.
I totally agree on this.
> By pulling this patchset now, we
> enable the possibility for implementing and testing it on other
> platforms sooner. Tom also seems to be willing to do so.
Jagan, I just saw your answer to the cover letter of the v5,
thanks for applying it.
Regards,
Miquèl
prev parent reply other threads:[~2018-07-31 7:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 12:31 [U-Boot] [PATCH v4 00/27] SPI-NAND support Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 01/27] mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 02/27] mtd: Uninline mtd_write_oob and move it to mtdcore.c Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 03/27] mtd: Add sanity checks in mtd_write/read_oob() Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 04/27] mtd: Fallback to ->_read/write() when ->_read/write_oob() is missing Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 05/27] mtd: add get/set of_node/flash_node helpers Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 06/27] mtd: fix build issue with includes Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 07/27] mtd: move definitions to enlarge their range Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 08/27] mtd: move all flash categories inside MTD submenu Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 09/27] mtd: move NAND files into a raw/ subdirectory Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 10/27] mtd: rename nand into rawnand in Kconfig prompt Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 11/27] mtd: nand: Add core infrastructure to deal with NAND devices Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 12/27] mtd: nand: Pass mode information to nand_page_io_req Miquel Raynal
2018-07-13 12:31 ` [U-Boot] [PATCH v4 13/27] spi: Extend the core to ease integration of SPI memory controllers Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 14/27] mtd: nand: Add core infrastructure to support SPI NANDs Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 15/27] mtd: spinand: Add initial support for Micron MT29F2G01ABAGD Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 16/27] mtd: spinand: Add initial support for Winbond W25M02GV Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 17/27] mtd: spinand: Add initial support for the MX35LF1GE4AB chip Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 18/27] mtd: spinand: Add initial support for the MX35LF2GE4AB chip Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 19/27] dt-bindings: Add bindings for SPI NAND devices Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 20/27] mtd: declare MTD_PARTITIONS symbol in Kconfig Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 21/27] cmd: ubi: delete useless and misleading definitions Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 22/27] cmd: mtdparts: accept spi-nand devices Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 23/27] cmd: mtdparts: add a generic 'mtdparts' parser Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 24/27] cmd: mtdparts: remove useless 'mtdparts=' prefix Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 25/27] mtd: uclass: add probe function Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 26/27] cmd: mtd: add 'mtd' command Miquel Raynal
2018-07-13 12:32 ` [U-Boot] [PATCH v4 27/27] cmd: mtdparts: try to probe the MTD devices as a fallback Miquel Raynal
2018-07-26 5:30 ` [U-Boot] [PATCH v4 00/27] SPI-NAND support Jagan Teki
2018-07-26 7:29 ` Miquel Raynal
2018-07-30 15:11 ` Stefan Roese
2018-07-30 15:23 ` Miquel Raynal
2018-07-30 16:10 ` Tom Rini
2018-07-31 5:36 ` Jagan Teki
2018-07-31 5:50 ` Stefan Roese
2018-07-31 7:37 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731093720.2b3d4db2@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox