public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 00/27] SPI-NAND support
Date: Tue, 31 Jul 2018 21:25:53 +0200	[thread overview]
Message-ID: <20180731212553.7f26b368@bbrezillon> (raw)
In-Reply-To: <CAMty3ZDjtkwYWnGX2NLRSrDTALPN8hY-4-ggap0iB_BGwEt=Uw@mail.gmail.com>

Hi Jagan,

On Tue, 31 Jul 2018 20:03:47 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:

> > Applied to u-boot-spi/master  
> 
> Look like we have some build issues [1]?

Yep, I reproduced the issue. Looks like u-boot Makefile hierarchy is a
bit different from Linux one, and patch is breaking raw/parallel NAND
build. I fixed it up (see below diff). This diff should be merged in
patch 9, and you'll have to fix a few conflicts when rebasing. Here is
a branch [1] containing this fixup commit (placed just after the
offending one) in case you want to check the end result. 

Regards,

Boris

[1]https://github.com/bbrezillon/u-boot/commits/wip-spi

--->8---
diff --git a/Makefile b/Makefile
index 884b7d943cf7..a38146003d77 100644
--- a/Makefile
+++ b/Makefile
@@ -685,7 +685,7 @@ libs-y += drivers/dma/
 libs-y += drivers/gpio/
 libs-y += drivers/i2c/
 libs-y += drivers/mtd/
-libs-$(CONFIG_CMD_NAND) += drivers/mtd/nand/
+libs-$(CONFIG_CMD_NAND) += drivers/mtd/nand/raw/
 libs-y += drivers/mtd/onenand/
 libs-$(CONFIG_CMD_UBI) += drivers/mtd/ubi/
 libs-y += drivers/mtd/spi/
diff --git a/drivers/Makefile b/drivers/Makefile
index 276e5ee4d7ee..ccd1b648d058 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -6,7 +6,7 @@ obj-$(CONFIG_$(SPL_TPL_)DRIVERS_MISC_SUPPORT) += misc/ sysreset/ firmware/
 obj-$(CONFIG_$(SPL_TPL_)I2C_SUPPORT) += i2c/
 obj-$(CONFIG_$(SPL_TPL_)LED) += led/
 obj-$(CONFIG_$(SPL_TPL_)MMC_SUPPORT) += mmc/
-obj-$(CONFIG_$(SPL_TPL_)NAND_SUPPORT) += mtd/nand/
+obj-$(CONFIG_$(SPL_TPL_)NAND_SUPPORT) += mtd/nand/raw/
 obj-$(CONFIG_$(SPL_TPL_)PHY) += phy/
 obj-$(CONFIG_$(SPL_TPL_)PINCTRL) += pinctrl/
 obj-$(CONFIG_$(SPL_TPL_)RAM) += ram/
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
index 8b2d0e118d1c..69f40d15635d 100644
--- a/drivers/mtd/nand/Makefile
+++ b/drivers/mtd/nand/Makefile
@@ -1,3 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0+
 
-obj-$(CONFIG_MTD_NAND) += raw/

  reply	other threads:[~2018-07-31 19:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 15:46 [U-Boot] [PATCH v5 00/27] SPI-NAND support Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 01/27] mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 02/27] mtd: Uninline mtd_write_oob and move it to mtdcore.c Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 03/27] mtd: Add sanity checks in mtd_write/read_oob() Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 04/27] mtd: Fallback to ->_read/write() when ->_read/write_oob() is missing Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 05/27] mtd: add get/set of_node/flash_node helpers Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 06/27] mtd: fix build issue with includes Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 07/27] mtd: move definitions to enlarge their range Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 08/27] mtd: move all flash categories inside MTD submenu Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 09/27] mtd: move NAND files into a raw/ subdirectory Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 10/27] mtd: rename nand into rawnand in Kconfig prompt Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 11/27] mtd: nand: Add core infrastructure to deal with NAND devices Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 12/27] mtd: nand: Pass mode information to nand_page_io_req Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 13/27] spi: Extend the core to ease integration of SPI memory controllers Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 14/27] mtd: nand: Add core infrastructure to support SPI NANDs Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 15/27] mtd: spinand: Add initial support for Micron MT29F2G01ABAGD Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 16/27] mtd: spinand: Add initial support for Winbond W25M02GV Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 17/27] mtd: spinand: Add initial support for the MX35LF1GE4AB chip Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 18/27] mtd: spinand: Add initial support for the MX35LF2GE4AB chip Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 19/27] dt-bindings: Add bindings for SPI NAND devices Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 20/27] mtd: declare MTD_PARTITIONS symbol in Kconfig Miquel Raynal
2018-07-31  7:24   ` Jagan Teki
2018-07-30 15:46 ` [U-Boot] [PATCH v5 21/27] cmd: ubi: delete useless and misleading definitions Miquel Raynal
2018-07-31  7:25   ` Jagan Teki
2018-07-30 15:46 ` [U-Boot] [PATCH v5 22/27] cmd: mtdparts: accept spi-nand devices Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 23/27] cmd: mtdparts: add a generic 'mtdparts' parser Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 24/27] cmd: mtdparts: remove useless 'mtdparts=' prefix Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 25/27] mtd: uclass: add probe function Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 26/27] cmd: mtd: add 'mtd' command Miquel Raynal
2018-07-30 15:46 ` [U-Boot] [PATCH v5 27/27] cmd: mtdparts: try to probe the MTD devices as a fallback Miquel Raynal
2018-07-31  7:29 ` [U-Boot] [PATCH v5 00/27] SPI-NAND support Jagan Teki
2018-07-31 14:33   ` Jagan Teki
2018-07-31 19:25     ` Boris Brezillon [this message]
2018-07-31 19:48       ` Boris Brezillon
2018-08-01  6:25       ` Jagan Teki
2018-08-01  8:14         ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2018-08-02 13:46 Jose Landeros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731212553.7f26b368@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox