public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] xyz-modem: Change getc timeout loop waiting
Date: Wed, 1 Aug 2018 07:54:31 +0200	[thread overview]
Message-ID: <20180801075431.765edc6d1eebfa0ccbf3693d@gmail.com> (raw)
In-Reply-To: <4f3ed6cb-cd68-8e78-38a5-5ab4f9fce305@vaisala.com>

Hi!

On Wed, 1 Aug 2018 08:44:13 +0300
Tomas Melin <tomas.melin@vaisala.com> wrote:

> > This commit breaks YMODEM SPL->U-Boot boot on Beagle Bone,
> > transfer is aborted (because of timeout) after 497kb
> > (u-boot.img is around 570kb).
> > Reverting the commit repairs YMODEM boot.
> 
> Is the timeout a watchdog timeout or some communication freeze?

I suppose, it reports false-positive timeout back to ymodem code.
Because all it does is terminating communication gracefully (with 'C'
and a bunch of CANs).
I need to check if timer overflow is possible on Beaglebone,
because the code is obviously not overflow-proof, but on the
other hand it happens within minutes and at least the timer variable
is 32 bit...

> In case watchdog is correctly configured, kicking should still
> happen.

-- 
Alexander Sverdlin.

  reply	other threads:[~2018-08-01  5:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  8:18 [U-Boot] [PATCH] xyz-modem: Change getc timeout loop waiting Tomas Melin
2016-11-29  1:07 ` [U-Boot] " Tom Rini
2018-08-01  0:15 ` Alexander Sverdlin
2018-08-01  5:44   ` Tomas Melin
2018-08-01  5:54     ` Alexander Sverdlin [this message]
2018-08-01  6:16       ` Tomas Melin
2018-08-02 14:47         ` Alexander Sverdlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801075431.765edc6d1eebfa0ccbf3693d@gmail.com \
    --to=alexander.sverdlin@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox