[U-Boot] [PATCH v6 00/27] SPI-NAND support

Miquel Raynal
2018-08-04T09:59:35Z

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Sat, 4 Aug 2018
10:34:55 +0200:

> On Sat, 4 Aug 2018 09:23:05 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > Hi Jagan,
> >
> > Jagan Teki <jagan@amarulasolutions.com> wrote on Fri, 3 Aug 2018
> > 17:38:33 +0530:
> >
> > > On Fri, Aug 3, 2018 at 3:20 PM, Jagan Teki <jagan@amarulasolutions.com> wrote:
> > > > On Fri, Aug 3, 2018 at 1:57 PM, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > >> Hi Jagan, Tom,
> > > >>
> > > >> Miquel Raynal <miquel.raynal@bootlin.com> wrote on Wed, 1 Aug 2018
> > > >> 10:18:21 +0200:
> > > >>
> > > >>> During the last months, Boris Brezillon shared his work to support
> > > >>> serial flashes within Linux. First, he delivered (and merged) a new
> > > >>> layer called spi-mem. He also initiated in Linux MTD subsystem the move
> > > >>> of all 'raw' NAND related code to a raw/ subdirectory, adding at the
> > > >>> same time a NAND core that would be shared with all NAND devices. Then,
> > > >>> he contributed a generic SPI-NAND driver, making use of this NAND core,
> > > >>> as well as some vendor code to drive a few chips.
> > > >>>
> > > >>> On top of this work, I added an 'mtd' U-Boot command to handle all sort
> > > >>> of MTD devices. This should become the default command instead of having
> > > >>> one per flash flavor ('sf', 'nand', 'spi-nand' ?).
> > > >>>
> > > >>> The series has been tested on an Ocelot board PCB123 (VSC7514),
> > > >>> featuring a Macronix SPI NAND chip.
> > > >>>
> > > >>> TL;DR: the series contains:
> > > >>> - A few patches from Linux to resynchronize some areas of the MTD layer.
> > > >>> - Various fixes and re-organization of the MTD subsystem.
> > > >>> - The introduction of the SPI-mem interface.
> > > >>> - The addition of the generic SPI-NAND driver (and its bindings).
> > > >>> - Several SPI NAND chip drivers (Macronix, Micron, Winbond).
> > > >>> - A new 'mtd' command.
> > > >>> - Support for spi-nand devices in mtdparts.
> > > >>>
> > > >>> To test your SPI-NAND device with U-Boot simply follow these lines:
> > > >>>
> > > >>> > setenv mtdparts mtdparts=spi-nand0:1m(foo),-(bar)
> > > >>> > setenv mtdids spi-nand0=spi-nand0
> > > >>> > mtdparts # show the spi-nand device partitions
> > > >>> > ubi part bar # create a static UBI volume in the bar partition
> > > >>>
> > > >>> Thanks,
> > > >>> Miquèl
> > > >>>
> > > >>> Changes since v5:
> > > >>> -----------------
> > > >>> * Included Boris fixup about the build issues.
> > > >>> * Added Rb/Ab tags from Jagan on patchs 20/21.
> > > >>
> > > >> I can't see a pull request flow on U-Boot ML, I suppose you use a
> > > >> different mean for that purpose.
> > > >>
> > > >> Jagan, is this version OK? Is it part of your PR?
> > > >
> > > > Travis is going on [1], will send PR once all fine.
> > > >
> > > > [1] https://travis-ci.org/openedev/u-boot-amarula/builds/411596788
> > >
> > > There are some build issues, not quite sure whether it relates. please
> > > look into it.
> >
> > Thanks for the reports.
> >
> > >
> > > [2] https://travis-ci.org/openedev/u-boot-amarula/jobs/411596814
> > > [3] https://travis-ci.org/openedev/u-boot-amarula/jobs/411596815
> >
> > Boris supposedly fixed all the build issues related to my changes (I
> > don't think the "missing interrupt parent" in a DTS file is related),
> > please pull his branch [1].
> >
> > The fixes are under the form of fixups if you wanna check them.
> > Otherwise you can just 'rebase -i --autosquash' to automatically squash
> > them with the commit introducing the regression.
>
> One more thing, if you want to make things bisectable patch 6 ("mtd: fix
> build issue with includes") and it's fixup should be squashed in patch 5
> ("mtd: add get/set of_node/flash_node helpers"), because the build
> failure you're fixing in patch 6 is introduced by patch 5.
>
> >
> > [1] https://travis-ci.org/openedev/u-boot-amarula/jobs/411596814
>
> You mean
>
> [1]https://github.com/bbrezillon/u-boot/commits/wip-spi

Oops!

Thanks,
Miquèl