public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] cmd: mtd: Add info text to mtd erase subcommand
Date: Mon, 6 Aug 2018 22:41:00 +0200	[thread overview]
Message-ID: <20180806224100.2357e7d4@bbrezillon> (raw)
In-Reply-To: <20180806151253.31205-4-sr@denx.de>

On Mon,  6 Aug 2018 17:12:53 +0200
Stefan Roese <sr@denx.de> wrote:

> Adding this info helps seeing, what really is being erased - especially
> if no arguments are passed for offset and size. Now this is the
> output:
> 
> => mtd erase spi-nand0  
> Erasing 0x00000000 ... 0x07ffffff (65536 page(s))
> nand: attempt to erase a bad/reserved block @6000000
> nand: attempt to erase a bad/reserved block @7fe0000
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
>  cmd/mtd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/cmd/mtd.c b/cmd/mtd.c
> index 38a89736cf..6d27698d1e 100644
> --- a/cmd/mtd.c
> +++ b/cmd/mtd.c
> @@ -355,6 +355,9 @@ static int do_mtd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  			return EINVAL;
>  		}
>  
> +		printf("Erasing 0x%08llx ... 0x%08llx (%d page(s))\n",
> +		       off, off + len - 1, mtd_len_to_pages(mtd, len));

Just a detail, but we usually count things in eraseblocks (not pages)
when erasing an MTD device (you can use mtd_div_by_eb(len, mtd) to do
that).

> +
>  		erase_op.mtd = mtd;
>  		erase_op.addr = off;
>  		erase_op.len = len;

  reply	other threads:[~2018-08-06 20:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 15:12 [U-Boot] [PATCH 1/4] spi: spi-mem: Add optional half-duplex SPI transfer mode Stefan Roese
2018-08-06 15:12 ` [U-Boot] [PATCH 2/4] mtd: nand: Don't abort erase operation when a bad block is detected Stefan Roese
2018-08-06 20:06   ` Boris Brezillon
2018-08-07  5:25     ` Stefan Roese
2018-08-06 15:12 ` [U-Boot] [PATCH 3/4] cmd: mtd: Don't use with negative return codes for shell commands Stefan Roese
2018-08-06 20:38   ` Boris Brezillon
2018-08-07  5:07     ` Stefan Roese
2018-08-06 15:12 ` [U-Boot] [PATCH 4/4] cmd: mtd: Add info text to mtd erase subcommand Stefan Roese
2018-08-06 20:41   ` Boris Brezillon [this message]
2018-08-07  5:08     ` Stefan Roese
2018-08-06 19:53 ` [U-Boot] [PATCH 1/4] spi: spi-mem: Add optional half-duplex SPI transfer mode Boris Brezillon
2018-08-07  5:06   ` Stefan Roese
2018-08-07  5:53     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180806224100.2357e7d4@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox