From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9 13/18] efi: Add a call to exit() along with why we can't use it
Date: Wed, 8 Aug 2018 03:54:28 -0600 [thread overview]
Message-ID: <20180808095433.230882-14-sjg@chromium.org> (raw)
In-Reply-To: <20180808095433.230882-1-sjg@chromium.org>
The test should exit like any other EFI application, by calling exit()
in the boot services API. But this crashes at present on sandbox. For now,
add in the placeholder code.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
lib/efi_loader/efi_test.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_test.c b/lib/efi_loader/efi_test.c
index 4b8d49f324b..5401a0f4715 100644
--- a/lib/efi_loader/efi_test.c
+++ b/lib/efi_loader/efi_test.c
@@ -9,8 +9,18 @@
int efi_test(efi_handle_t image_handle, struct efi_system_table *systable)
{
struct efi_simple_text_output_protocol *con_out = systable->con_out;
+ struct efi_boot_services *boottime = systable->boottime;
+ int ret;
- con_out->output_string(con_out, L"Hello, world!\n");
+ ret = con_out->output_string(con_out, L"Hello, world!\n");
+
+ /*
+ * We should really call EFI's exit() here but this crashes at present
+ * on sandbox due to the incorrect use of setjmp() and longjmp(). Once
+ * we can figure out how to make that work, this can be enabled.
+ */
+ if (0)
+ boottime->exit(image_handle, ret, 0, NULL);
return 0;
}
--
2.18.0.597.ga71716f1ad-goog
next prev parent reply other threads:[~2018-08-08 9:54 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 9:54 [U-Boot] [PATCH v9 00/18] efi: Enable sandbox support for EFI loader Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 01/18] Revert "efi_loader: Rename sections to allow for implicit data" Simon Glass
2018-08-23 20:18 ` [U-Boot] [U-Boot, v9, 01/18] Partially revert " Tom Rini
2018-08-08 9:54 ` [U-Boot] [PATCH v9 02/18] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox Simon Glass
2018-08-26 16:53 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 03/18] efi: sandbox: Add distroboot support Simon Glass
2018-08-26 16:54 ` Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 04/18] efi: sandbox: Enable EFI loader build for sandbox Simon Glass
2018-08-26 16:55 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-09-15 8:11 ` Alexander Graf
2018-09-15 8:32 ` Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 05/18] efi: Split out test init/uninit into functions Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 06/18] efi: sandbox: Add a simple 'bootefi test' command Simon Glass
2018-08-26 16:58 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 07/18] efi: Create a function to set up for running EFI code Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 08/18] efi: Rename bootefi_test_finish() to bootefi_run_finish() Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 09/18] sandbox: Align RAM buffer to the machine page size Simon Glass
2018-08-26 17:01 ` Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 10/18] sandbox: Try to start the RAM buffer at a particular address Simon Glass
2018-08-26 17:01 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-10-15 20:07 ` Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 11/18] sandbox: Add support for calling abort() Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 12/18] sandbox: Enhance map_to_sysmem() to handle foreign pointers Simon Glass
2018-08-26 17:11 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-09-15 8:16 ` Alexander Graf
2018-09-15 8:31 ` Simon Glass
2018-08-08 9:54 ` Simon Glass [this message]
2018-08-23 20:37 ` [U-Boot] [PATCH v9 13/18] efi: Add a call to exit() along with why we can't use it Heinrich Schuchardt
2018-08-26 17:13 ` Alexander Graf
2018-09-14 15:46 ` Simon Glass
2018-08-08 9:54 ` [U-Boot] [PATCH v9 14/18] efi: Relocate FDT to 127MB instead of 128MB Simon Glass
2018-08-26 17:23 ` [U-Boot] [U-Boot, v9, " Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 15/18] efi: sandbox: Tidy up copy_fdt() to work with sandbox Simon Glass
2018-08-26 17:23 ` [U-Boot] [U-Boot, v9, " Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 16/18] efi: Add more debugging for memory allocations Simon Glass
2018-08-23 20:49 ` Heinrich Schuchardt
2018-08-26 18:27 ` Simon Glass
2018-08-26 17:22 ` Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 17/18] efi_loader: Pass address to fs_read() Simon Glass
2018-08-26 17:23 ` [U-Boot] [U-Boot, v9, " Alexander Graf
2018-08-08 9:54 ` [U-Boot] [PATCH v9 18/18] efi: sandbox: Enable selftest command Simon Glass
2018-08-26 17:28 ` [U-Boot] [PATCH v9 00/18] efi: Enable sandbox support for EFI loader Alexander Graf
2018-09-14 15:46 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808095433.230882-14-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox