From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Fri, 10 Aug 2018 16:19:17 +0200 Subject: [U-Boot] [PATCH V3 08/32] misc: imx8: add scfw api impementation In-Reply-To: <20180806025047.25320-9-peng.fan@nxp.com> References: <20180806025047.25320-1-peng.fan@nxp.com> <20180806025047.25320-9-peng.fan@nxp.com> Message-ID: <20180810161917.20df2886@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 6 Aug 2018 10:50:23 +0800 Peng Fan peng.fan at nxp.com wrote: > Add clk/misc/pad/pm/rm scfw api implementaion for different > drivers to invoke. The low level code is using misc_call > to invoke imx8_scu driver. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > --- > arch/arm/include/asm/arch-imx8/sci/sci.h | 31 +++++++++- > drivers/misc/imx8/Makefile | 2 +- > drivers/misc/imx8/clk.c | 93 ++++++++++++++++++++++++++++++ > drivers/misc/imx8/misc.c | 88 +++++++++++++++++++++++++++++ > drivers/misc/imx8/pad.c | 39 +++++++++++++ > drivers/misc/imx8/pm.c | 38 +++++++++++++ > drivers/misc/imx8/rm.c | 97 ++++++++++++++++++++++++++++++++ > 7 files changed, 386 insertions(+), 2 deletions(-) > create mode 100644 drivers/misc/imx8/clk.c > create mode 100644 drivers/misc/imx8/misc.c > create mode 100644 drivers/misc/imx8/pad.c > create mode 100644 drivers/misc/imx8/pm.c > create mode 100644 drivers/misc/imx8/rm.c What about adding a single file (scu-api.c ?) with all API functions? > diff --git a/arch/arm/include/asm/arch-imx8/sci/sci.h b/arch/arm/include/asm/arch-imx8/sci/sci.h > index b7280aee05..4704ba9699 100644 > --- a/arch/arm/include/asm/arch-imx8/sci/sci.h > +++ b/arch/arm/include/asm/arch-imx8/sci/sci.h > @@ -46,7 +46,8 @@ static inline int sc_err_to_linux(sc_err_t err) > ret = -EIO; > break; > default: > - panic("Invalid sc_err_t value\n"); > + ret = 0; > + break; > } Please move this to patch 4/32 that adds sci.h file. -- Anatolij