* [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS
@ 2018-08-13 22:00 Ramon Fried
2018-08-13 22:10 ` Marek Vasut
2018-08-17 2:05 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Ramon Fried @ 2018-08-13 22:00 UTC (permalink / raw)
To: u-boot
Move CONFIG_NR_DRAM_BANKS from headers to Kconfig.
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---
Kconfig | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Kconfig b/Kconfig
index db0f545e45..d96e3373c1 100644
--- a/Kconfig
+++ b/Kconfig
@@ -104,6 +104,12 @@ config ENV_VARS_UBOOT_CONFIG
- CONFIG_SYS_VENDOR
- CONFIG_SYS_SOC
+config NR_DRAM_BANKS
+ int "Number of DRAM banks"
+ default 4
+ help
+ This defines the number of DRAM banks.
+
config SYS_BOOT_GET_CMDLINE
bool "Enable kernel command line setup"
help
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS
2018-08-13 22:00 [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS Ramon Fried
@ 2018-08-13 22:10 ` Marek Vasut
2018-08-14 7:23 ` Ramon Fried
2018-08-17 2:05 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2018-08-13 22:10 UTC (permalink / raw)
To: u-boot
On 08/14/2018 12:00 AM, Ramon Fried wrote:
> Move CONFIG_NR_DRAM_BANKS from headers to Kconfig.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Somehow this seems to be missing a lot of cleanups in include/configs/
... look at moveconfig.py
> ---
> Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Kconfig b/Kconfig
> index db0f545e45..d96e3373c1 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -104,6 +104,12 @@ config ENV_VARS_UBOOT_CONFIG
> - CONFIG_SYS_VENDOR
> - CONFIG_SYS_SOC
>
> +config NR_DRAM_BANKS
> + int "Number of DRAM banks"
> + default 4
> + help
> + This defines the number of DRAM banks.
> +
> config SYS_BOOT_GET_CMDLINE
> bool "Enable kernel command line setup"
> help
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS
2018-08-13 22:10 ` Marek Vasut
@ 2018-08-14 7:23 ` Ramon Fried
2018-08-14 8:32 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Ramon Fried @ 2018-08-14 7:23 UTC (permalink / raw)
To: u-boot
On Tue, Aug 14, 2018 at 1:11 AM Marek Vasut <marex@denx.de> wrote:
> On 08/14/2018 12:00 AM, Ramon Fried wrote:
> > Move CONFIG_NR_DRAM_BANKS from headers to Kconfig.
> >
> > Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
>
> Somehow this seems to be missing a lot of cleanups in include/configs/
> ... look at moveconfig.py
>
Indeed, Tom said he'll handle that :)
>
> > ---
> > Kconfig | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Kconfig b/Kconfig
> > index db0f545e45..d96e3373c1 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -104,6 +104,12 @@ config ENV_VARS_UBOOT_CONFIG
> > - CONFIG_SYS_VENDOR
> > - CONFIG_SYS_SOC
> >
> > +config NR_DRAM_BANKS
> > + int "Number of DRAM banks"
> > + default 4
> > + help
> > + This defines the number of DRAM banks.
> > +
> > config SYS_BOOT_GET_CMDLINE
> > bool "Enable kernel command line setup"
> > help
> >
>
>
> --
> Best regards,
> Marek Vasut
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS
2018-08-14 7:23 ` Ramon Fried
@ 2018-08-14 8:32 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2018-08-14 8:32 UTC (permalink / raw)
To: u-boot
On 08/14/2018 09:23 AM, Ramon Fried wrote:
>
>
> On Tue, Aug 14, 2018 at 1:11 AM Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
>
> On 08/14/2018 12:00 AM, Ramon Fried wrote:
> > Move CONFIG_NR_DRAM_BANKS from headers to Kconfig.
> >
> > Signed-off-by: Ramon Fried <ramon.fried@gmail.com
> <mailto:ramon.fried@gmail.com>>
>
> Somehow this seems to be missing a lot of cleanups in include/configs/
> ... look at moveconfig.py
>
> Indeed, Tom said he'll handle that :)
This looks like it's gonna be quite involved. If Tom wants to do it,
that's fine by me, but this patch shouldn't be applied without the cleanup.
> > ---
> > Kconfig | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Kconfig b/Kconfig
> > index db0f545e45..d96e3373c1 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -104,6 +104,12 @@ config ENV_VARS_UBOOT_CONFIG
> > - CONFIG_SYS_VENDOR
> > - CONFIG_SYS_SOC
> >
> > +config NR_DRAM_BANKS
> > + int "Number of DRAM banks"
> > + default 4
> > + help
> > + This defines the number of DRAM banks.
> > +
> > config SYS_BOOT_GET_CMDLINE
> > bool "Enable kernel command line setup"
> > help
> >
>
>
> --
> Best regards,
> Marek Vasut
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] Kconfig: Migrate CONFIG_NR_DRAM_BANKS
2018-08-13 22:00 [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS Ramon Fried
2018-08-13 22:10 ` Marek Vasut
@ 2018-08-17 2:05 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2018-08-17 2:05 UTC (permalink / raw)
To: u-boot
On Tue, Aug 14, 2018 at 01:00:04AM +0300, Ramon Fried wrote:
> Move CONFIG_NR_DRAM_BANKS from headers to Kconfig.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180816/a4d792ca/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-17 2:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-13 22:00 [U-Boot] [PATCH] Kconfig: Migrate CONFIG_NR_DRAM_BANKS Ramon Fried
2018-08-13 22:10 ` Marek Vasut
2018-08-14 7:23 ` Ramon Fried
2018-08-14 8:32 ` Marek Vasut
2018-08-17 2:05 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox