From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
Date: Thu, 16 Aug 2018 20:25:44 +0200
Subject: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as
 dependent on PARTITION_UUIDS
In-Reply-To: <CAModR+UmByc96RR1_vR0nVc0HJAjzLq9j8Z+Rea=WE9AD9g1nQ@mail.gmail.com>
References: <20180814004309.15271-1-erosca@de.adit-jv.com>
 <20180814004309.15271-3-erosca@de.adit-jv.com>
 <CAModR+UmByc96RR1_vR0nVc0HJAjzLq9j8Z+Rea=WE9AD9g1nQ@mail.gmail.com>
Message-ID: <20180816182544.GA20904@x230>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Igor,

First, thanks for the reviews!

On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote:
> Hi Eugeniu,
> 
> Why not keep all dependencies on the same line in this case? Simply:
> depends LIBAVB && FASTBOOT && PARTITION_UUIDS

I guess it's a matter of personal preference (but maybe not entirely).
Let's say one needs to replace "depends on PARTITION_UUIDS" with
"select PARTITION_UUIDS" due to e.g. a circular dependency detected
by Kconfig at some point. For me below two lines:

- depends on PARTITION_UUIDS
+ select PARTITION_UUIDS

look more readable and are easier to review than:

- depends LIBAVB && FASTBOOT && PARTITION_UUIDS
+ depends LIBAVB && FASTBOOT
+ select PARTITION_UUIDS

I still can update the patch. Just let me know.

> 
> Regards,
> Igor

Best regards,
Eugeniu.