public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] Import Undefined Behavior Sanitizer
Date: Sun, 19 Aug 2018 21:51:24 -0400	[thread overview]
Message-ID: <20180820015124.GE11769@bill-the-cat> (raw)
In-Reply-To: <20180820000033.25519-1-erosca@de.adit-jv.com>

On Mon, Aug 20, 2018 at 02:00:24AM +0200, Eugeniu Rosca wrote:

> While certain classes of bugs (e.g. locking related) are totally
> irrelevant for U-Boot, undefined behavior is something U-Boot may
> experience all over the place and this certainly can lead to hidden
> and difficult to debug issues.
> 
> As of v4.18, Linux kernel contains roughly 119 UBSAN fixes [1]. Hence
> the sanity checker has been quite a productive and useful tool to play
> with during development.
> 
> Thanks to UBSAN, this series proposes 7 (+1 in [2]) UB fixes, revealed
> by a simple cold boot of sandbox and arm64 R-Car Gen3 U-Boot. There
> could be more issues in arch/platform/board-specific code, whose
> reproduction needs specific hardware.
> 
> A certain class of UBs [3] is reported regularly at runtime and looks
> to be related to the implementation of U-Boot linker-generated arrays.
> I believe some feedback from the authors/maintainers of those is
> required to assess if this is a UBSAN false positive or a real bug.
> 
> This series collects the low-hanging fruit and leaves others to
> experiment with UBSAN themselves.

Thanks for doing this, and I am totally behind the idea.  Further, given
the QEMU-based setups we have available it could be interesting to run
some of them those as well (and further the list of places this could be
run on).  That said, I have some specific patch feedback to follow.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180819/1566c6b5/attachment.sig>

      parent reply	other threads:[~2018-08-20  1:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  0:00 [U-Boot] [PATCH 0/8] Import Undefined Behavior Sanitizer Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 1/8] UBSAN: run-time undefined behavior sanity checker Eugeniu Rosca
2018-08-20  1:51   ` Tom Rini
2018-08-20 12:54     ` Eugeniu Rosca
2018-08-20 17:50       ` Tom Rini
2018-08-20 15:00   ` York Sun
2018-08-20 21:00     ` Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 2/8] mmc: Fix "left shift in type int" undefined behavior Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 3/8] armv8: mmu: " Eugeniu Rosca
2018-08-20  1:51   ` Tom Rini
2018-08-20 13:24     ` Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 4/8] pinctrl: renesas: " Eugeniu Rosca
2018-08-20  8:07   ` Marek Vasut
2018-08-20 13:42     ` Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 5/8] net: phy: " Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 6/8] net: ravb: " Eugeniu Rosca
2018-08-20  8:05   ` Marek Vasut
2018-08-20  0:00 ` [U-Boot] [PATCH 7/8] mmc: Fix read-past-end-of-array " Eugeniu Rosca
2018-08-20  0:00 ` [U-Boot] [PATCH 8/8] hashtable: Fix zero-sized array " Eugeniu Rosca
2018-08-20  1:51   ` Tom Rini
2018-08-20  1:51 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820015124.GE11769@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox