From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Mon, 20 Aug 2018 18:08:14 +0200 Subject: [U-Boot] [PATCH v6 29/31] cmd: mtd: add 'mtd' command In-Reply-To: <20180816182203.6b89f3de@bbrezillon> References: <20180816153029.15521-1-miquel.raynal@bootlin.com> <20180816153029.15521-30-miquel.raynal@bootlin.com> <20180816182203.6b89f3de@bbrezillon> Message-ID: <20180820180814.739e9f25@xps13> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Boris, Boris Brezillon wrote on Thu, 16 Aug 2018 18:22:03 +0200: > On Thu, 16 Aug 2018 17:30:27 +0200 > Miquel Raynal wrote: >=20 > > There should not be a 'nand' command, a 'sf' command and certainly not > > a new 'spi-nand' command. Write a 'mtd' command instead to manage all > > MTD devices/partitions at once. This should be the preferred way to > > access any MTD device. > >=20 > > Signed-off-by: Miquel Raynal > > Acked-by: Jagan Teki =20 >=20 > [...] >=20 > > =20 > > +config CMD_MTD > > + bool "mtd" > > + depends on CMD_MTDPARTS =20 >=20 > Shouldn't we select it instead? No need anymore, I will entirely re-write the functions that are needed to have stateless clean MTD functions taking the best out of the MTD stack. All of them will be in mtd-uclass.c, declared in include/mtd.h. >=20 > > + select MTD_PARTITIONS > > + help > > + MTD commands support. > > + =20 >=20 Thanks, Miqu=C3=A8l