From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Brezillon <boris.brezillon@bootlin.com>
Date: Mon, 20 Aug 2018 18:30:31 +0200
Subject: [U-Boot] [PATCH v6 29/31] cmd: mtd: add 'mtd' command
In-Reply-To: <20180820180814.739e9f25@xps13>
References: <20180816153029.15521-1-miquel.raynal@bootlin.com>
 <20180816153029.15521-30-miquel.raynal@bootlin.com>
 <20180816182203.6b89f3de@bbrezillon>
 <20180820180814.739e9f25@xps13>
Message-ID: <20180820183031.6aa7746d@bbrezillon>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 20 Aug 2018 18:08:14 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Boris,
> 
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 16 Aug 2018
> 18:22:03 +0200:
> 
> > On Thu, 16 Aug 2018 17:30:27 +0200
> > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >   
> > > There should not be a 'nand' command, a 'sf' command and certainly not
> > > a new 'spi-nand' command. Write a 'mtd' command instead to manage all
> > > MTD devices/partitions at once. This should be the preferred way to
> > > access any MTD device.
> > > 
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > Acked-by: Jagan Teki <jagan@openedev.com>    
> > 
> > [...]
> >   
> > >  
> > > +config CMD_MTD
> > > +	bool "mtd"
> > > +	depends on CMD_MTDPARTS    
> > 
> > Shouldn't we select it instead?  
> 
> No need anymore, I will entirely re-write the functions that are needed
> to have stateless clean MTD functions taking the best out of the MTD
> stack.
> 
> All of them will be in mtd-uclass.c, declared in include/mtd.h.

Hm, I would have put those functions in mtdpart.c, but, as long as
mtd-uclass.c is compiled even if CONFIG_DM is not enabled I'm fine with
that.