From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3.2 14/58] musb-new: sunxi: Use CLK and RESET support
Date: Wed, 22 Aug 2018 17:54:37 +0200 [thread overview]
Message-ID: <20180822155437.o2hihdv4qx63kziy@flea> (raw)
In-Reply-To: <20180820163231.4706-1-jagan@amarulasolutions.com>
Hi,
On Mon, Aug 20, 2018 at 10:02:31PM +0530, Jagan Teki wrote:
> - glue->ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
> - if (IS_ERR(glue->ccm))
> - return PTR_ERR(glue->ccm);
> + if (glue->cfg->has_reset)
> + test_and_set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
I'm not sure why the flag is needed here. It's completely redundant
with the boolean you're testing to set that flag.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180822/447b265b/attachment.sig>
next prev parent reply other threads:[~2018-08-22 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 16:32 [U-Boot] [PATCH v3.2 14/58] musb-new: sunxi: Use CLK and RESET support Jagan Teki
2018-08-22 15:54 ` Maxime Ripard [this message]
2018-08-22 16:03 ` Jagan Teki
2018-08-23 12:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822155437.o2hihdv4qx63kziy@flea \
--to=maxime.ripard@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox