From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Thu, 23 Aug 2018 14:44:18 +0200 Subject: [U-Boot] [PATCH v3.2 14/58] musb-new: sunxi: Use CLK and RESET support In-Reply-To: References: <20180820163231.4706-1-jagan@amarulasolutions.com> <20180822155437.o2hihdv4qx63kziy@flea> Message-ID: <20180823124418.5yht2vxulg2by2mx@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Aug 22, 2018 at 09:33:27PM +0530, Jagan Teki wrote: > On Wed, Aug 22, 2018 at 9:24 PM, Maxime Ripard > wrote: > > Hi, > > > > On Mon, Aug 20, 2018 at 10:02:31PM +0530, Jagan Teki wrote: > >> - glue->ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE; > >> - if (IS_ERR(glue->ccm)) > >> - return PTR_ERR(glue->ccm); > >> + if (glue->cfg->has_reset) > >> + test_and_set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags); > > > > I'm not sure why the flag is needed here. It's completely redundant > > with the boolean you're testing to set that flag. > > Since the reset is optional, set the flag for reset required SoC's > instead of using reset_get_by_index_optional Yeah, I understood the intent, but you can remove the flag and use glue->cfg->has_reset. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: