From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 24 Aug 2018 16:09:37 -0400 Subject: [U-Boot] [U-Boot, 1/7] libavb: Handle wrong hashtree_error_mode in avb_append_options() In-Reply-To: <20180814004309.15271-1-erosca@de.adit-jv.com> References: <20180814004309.15271-1-erosca@de.adit-jv.com> Message-ID: <20180824200937.GE26633@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Tue, Aug 14, 2018 at 02:43:03AM +0200, Eugeniu Rosca wrote: > From: Ievgen Maliarenko > > Exit with AVB_SLOT_VERIFY_RESULT_ERROR_INVALID_ARGUMENT > when hashtree_error_mode value passed to avb_append_options() > is unknown (not from AvbHashtreeErrorMode enum). > > Otherwise, default value is not handled in the > switch(hashtree_error_mode), which causes below compile warning: > > lib/libavb/avb_cmdline.c: In function ‘avb_append_options’: > lib/libavb/avb_cmdline.c:354:13: warning: ‘dm_verity_mode’ may be used uninitialized in this function [-Wmaybe-uninitialized] > new_ret = avb_replace( > ~~~~~~~~^~~~~~~~~~~~~~ > slot_data->cmdline, "$(ANDROID_VERITY_MODE)", dm_verity_mode); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > lib/libavb/avb_cmdline.c:363:8: warning: ‘verity_mode’ may be used uninitialized in this function [-Wmaybe-uninitialized] > if (!cmdline_append_option( > ^~~~~~~~~~~~~~~~~~~~~~ > slot_data, "androidboot.veritymode", verity_mode)) { > > Signed-off-by: Ievgen Maliarenko > Signed-off-by: Eugeniu Rosca > Reviewed-by: Igor Opaniuk Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: