public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding
@ 2018-08-21 15:04 Christian.Amann at de.bosch.com
  2018-08-24 20:10 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Christian.Amann at de.bosch.com @ 2018-08-21 15:04 UTC (permalink / raw)
  To: u-boot

From: Christian Amann <Christian.Amann@de.bosch.com>

Copy missing Kernel patch to make SLEWCTRL_SLOW available in device tree
and to correct the value of SLEWCTRL_FAST.
After this patch, the Kernel and U-boot device tree settings for
SLEWCTRL have the same effect.

Original Kernel patch message:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=424e0f039bfa8a51fb5c5178b6ece8baa4996469

"
According to AM335x TRM, Document spruh73l, Revised February 2015,
Section 9.2.2 Pad Control Registers, setting bit 6 of the pad control
registers actually sets the SLEWCTRL value to slow rather than fast as
the current macro indicates. Introduce a new macro, SLEWCTRL_SLOW, that
sets the bit, and modify SLEWCTRL_FAST to 0 but keep it for
completeness. Current users of the macro (i2c and mdio) are left
unmodified as SLEWCTRL_FAST was the macro used and actual desired state.
Tested on am335x-gp-evm with no difference in software performance seen.
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
"

Signed-off-by: Christian Amann <Christian.Amann@de.bosch.com>
---
 include/dt-bindings/pinctrl/am33xx.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/pinctrl/am33xx.h b/include/dt-bindings/pinctrl/am33xx.h
index 2fbc804..226f772 100644
--- a/include/dt-bindings/pinctrl/am33xx.h
+++ b/include/dt-bindings/pinctrl/am33xx.h
@@ -13,7 +13,8 @@
 
 #define PULL_DISABLE		(1 << 3)
 #define INPUT_EN		(1 << 5)
-#define SLEWCTRL_FAST		(1 << 6)
+#define SLEWCTRL_SLOW		(1 << 6)
+#define SLEWCTRL_FAST		0
 
 /* update macro depending on INPUT_EN and PULL_ENA */
 #undef PIN_OUTPUT
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding
  2018-08-21 15:04 [U-Boot] [PATCH] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding Christian.Amann at de.bosch.com
@ 2018-08-24 20:10 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-08-24 20:10 UTC (permalink / raw)
  To: u-boot

On Tue, Aug 21, 2018 at 05:04:09PM +0200, Christian.Amann at de.bosch.com wrote:

> From: Christian Amann <Christian.Amann@de.bosch.com>
> 
> Copy missing Kernel patch to make SLEWCTRL_SLOW available in device tree
> and to correct the value of SLEWCTRL_FAST.
> After this patch, the Kernel and U-boot device tree settings for
> SLEWCTRL have the same effect.
> 
> Original Kernel patch message:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=424e0f039bfa8a51fb5c5178b6ece8baa4996469
> 
> "
> According to AM335x TRM, Document spruh73l, Revised February 2015,
> Section 9.2.2 Pad Control Registers, setting bit 6 of the pad control
> registers actually sets the SLEWCTRL value to slow rather than fast as
> the current macro indicates. Introduce a new macro, SLEWCTRL_SLOW, that
> sets the bit, and modify SLEWCTRL_FAST to 0 but keep it for
> completeness. Current users of the macro (i2c and mdio) are left
> unmodified as SLEWCTRL_FAST was the macro used and actual desired state.
> Tested on am335x-gp-evm with no difference in software performance seen.
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> "
> 
> Signed-off-by: Christian Amann <Christian.Amann@de.bosch.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180824/60022aa4/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-24 20:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-21 15:04 [U-Boot] [PATCH] ARM: dts: am33xx: fix SLEWCTRL_FAST pinctrl binding Christian.Amann at de.bosch.com
2018-08-24 20:10 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox