* [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init
@ 2018-08-28 20:26 Jasper Kcoding
2018-09-03 12:57 ` Neil Armstrong
2018-09-03 20:14 ` Jasper kcoding
0 siblings, 2 replies; 4+ messages in thread
From: Jasper Kcoding @ 2018-08-28 20:26 UTC (permalink / raw)
To: u-boot
Without this patch the Ethernet PHY on the p212 board does not get fully configured.
When this happens Ethernet does not function.
The similar libretech-cc and khadas-vim boards have this code already.
That's why the Ethernet on these boards do work.
---
board/amlogic/p212/p212.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
index 06c2eaee47..d5ce5397f3 100644
--- a/board/amlogic/p212/p212.c
+++ b/board/amlogic/p212/p212.c
@@ -29,7 +29,7 @@ int misc_init_r(void)
char serial[EFUSE_SN_SIZE];
ssize_t len;
- meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+ meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, MESON_GXL_USE_INTERNAL_RMII_PHY);
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init
2018-08-28 20:26 [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init Jasper Kcoding
@ 2018-09-03 12:57 ` Neil Armstrong
2018-09-03 20:14 ` Jasper kcoding
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-09-03 12:57 UTC (permalink / raw)
To: u-boot
Hi jasper,
On 28/08/2018 22:26, Jasper Kcoding wrote:
> Without this patch the Ethernet PHY on the p212 board does not get fully configured.
> When this happens Ethernet does not function.
>
> The similar libretech-cc and khadas-vim boards have this code already.
> That's why the Ethernet on these boards do work.
Please add a "Signed-off-by" tag.
> ---
> board/amlogic/p212/p212.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
> index 06c2eaee47..d5ce5397f3 100644
> --- a/board/amlogic/p212/p212.c
> +++ b/board/amlogic/p212/p212.c
> @@ -29,7 +29,7 @@ int misc_init_r(void)
> char serial[EFUSE_SN_SIZE];
> ssize_t len;
>
> - meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
> + meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, MESON_GXL_USE_INTERNAL_RMII_PHY);
>
> if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
> len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Please resend with my Acked-by tag !
Thanks for fixing this...
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init
2018-08-28 20:26 [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init Jasper Kcoding
2018-09-03 12:57 ` Neil Armstrong
@ 2018-09-03 20:14 ` Jasper kcoding
2018-09-06 13:45 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 4+ messages in thread
From: Jasper kcoding @ 2018-09-03 20:14 UTC (permalink / raw)
To: u-boot
Without this patch the Ethernet PHY on the p212 board does not get
fully configured.
When this happens Ethernet does not function.
The similar libretech-cc and khadas-vim boards have this code already.
That's why the Ethernet on these boards do work.
Signed-off-by: Jasper Kcoding <jasperkcoding@gmail.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
---
board/amlogic/p212/p212.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
index 06c2eaee47..d5ce5397f3 100644
--- a/board/amlogic/p212/p212.c
+++ b/board/amlogic/p212/p212.c
@@ -29,7 +29,7 @@ int misc_init_r(void)
char serial[EFUSE_SN_SIZE];
ssize_t len;
- meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+ meson_gx_eth_init(PHY_INTERFACE_MODE_RMII,
MESON_GXL_USE_INTERNAL_RMII_PHY);
if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] amlogic: board p212: Fix Ethernet PHY init
2018-09-03 20:14 ` Jasper kcoding
@ 2018-09-06 13:45 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2018-09-06 13:45 UTC (permalink / raw)
To: u-boot
On Mon, Sep 03, 2018 at 10:14:53PM +0200, Jasper kcoding wrote:
> Without this patch the Ethernet PHY on the p212 board does not get
> fully configured.
> When this happens Ethernet does not function.
>
> The similar libretech-cc and khadas-vim boards have this code already.
> That's why the Ethernet on these boards do work.
>
> Signed-off-by: Jasper Kcoding <jasperkcoding@gmail.com>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180906/406d104b/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-06 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-28 20:26 [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init Jasper Kcoding
2018-09-03 12:57 ` Neil Armstrong
2018-09-03 20:14 ` Jasper kcoding
2018-09-06 13:45 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox