public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] Makefile: Don't generate position independent code
Date: Mon, 3 Sep 2018 10:57:57 +0300	[thread overview]
Message-ID: <20180903075757.GG11447@smile.fi.intel.com> (raw)
In-Reply-To: <CAPnjgZ2oXgwJ4RHhpuGe+Thc_bodMnx3zUa1DRz3JCGBDS-J1Q@mail.gmail.com>

On Sun, Sep 02, 2018 at 05:50:24PM -0600, Simon Glass wrote:
> Hi,
> 
> On 10 August 2018 at 00:04, Bin Meng <bmeng.cn@gmail.com> wrote:
> > On Thu, Aug 9, 2018 at 9:07 PM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >> On Thu, 2018-08-09 at 14:25 +0200, Heinrich Schuchardt wrote:
> >>
> >>>  I did not test loading of
> >>> Linux on x86.
> >>
> >> For the record I did test this.
> >>
> >
> > Tested-by: Bin Meng <bmeng.cn@gmail.com>
> > On QEMU x86 boards (except efi-x86_app_defconfig which is currently broken)
> >
> > applied to u-boot-x86, thanks!
> 
> This appears to break build sandbox on Ubuntu 18.04 at least (gcc-7.3).

Sandbox is not a real bootloader for sure :-)

Does the below cure?

diff --git a/arch/sandbox/config.mk b/arch/sandbox/config.mk
index 5e7077bfe7..4599839791 100644
--- a/arch/sandbox/config.mk
+++ b/arch/sandbox/config.mk
@@ -3,6 +3,7 @@
 
 PLATFORM_CPPFLAGS += -D__SANDBOX__ -U_FORTIFY_SOURCE
 PLATFORM_CPPFLAGS += -DCONFIG_ARCH_MAP_SYSMEM
+PLATFORM_CPPFLAGS += -fPIC
 PLATFORM_LIBS += -lrt
 
 LDFLAGS_FINAL += --gc-sections


> Can we revert it, or do something else stop it from happening with sandbox?
> 
> At present all testing is broken for me.

-- 
With Best Regards,
Andy Shevchenko

      reply	other threads:[~2018-09-03  7:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 16:00 [U-Boot] [PATCH v1] Makefile: Don't generate position independent code Andy Shevchenko
2018-08-06 16:56 ` Heinrich Schuchardt
2018-08-06 17:11   ` Andy Shevchenko
2018-08-06 17:32     ` Heinrich Schuchardt
2018-08-06 18:55       ` Andy Shevchenko
2018-08-06 19:40         ` Heinrich Schuchardt
2018-08-06 19:49           ` Andy Shevchenko
2018-08-09  9:43             ` Andy Shevchenko
2018-08-09  9:54               ` Bin Meng
2018-08-09 12:25                 ` Heinrich Schuchardt
2018-08-09 13:07                   ` Andy Shevchenko
2018-08-10  6:04                     ` Bin Meng
2018-09-02 23:50                       ` Simon Glass
2018-09-03  7:57                         ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903075757.GG11447@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox