From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Mon, 3 Sep 2018 10:50:33 +0200 Subject: [U-Boot] [PATCH v6 20/31] mtd: declare MTD_PARTITIONS symbol in Kconfig In-Reply-To: References: <20180816153029.15521-1-miquel.raynal@bootlin.com> <20180816153029.15521-21-miquel.raynal@bootlin.com> Message-ID: <20180903105033.305be550@xps13> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Jagan, Jagan Teki wrote on Mon, 3 Sep 2018 13:17:13 +0530: > On Thu, Aug 16, 2018 at 9:00 PM, Miquel Raynal > wrote: > > UBI selects MTD_PARTITIONS which is the symbol to compile > > drivers/mtd/mtdpart.c. Unfortunately, the symbol was not defined in > > Kconfig and this worked only with board files defining it. Fix this by > > adding a boolean in Kconfig so boards defined by defconfig files only > > will work as expected. > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/mtd/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > > index 9341d518f3..d98457e223 100644 > > --- a/drivers/mtd/Kconfig > > +++ b/drivers/mtd/Kconfig > > @@ -1,5 +1,8 @@ > > menu "MTD Support" > > > > +config MTD_PARTITIONS > > + bool > > + =20 >=20 > I think I can drop this patch, along with > "mtd: declare MTD_PARTITIONS symbol in Kconfig" Oh I see what you mean! It looks like the problem reported here has already been fixed by: commit 9c5b00973bceb7c0192bd6b03672d69b092700b4 Author: Adam Ford Date: Sat Jul 7 22:18:22 2018 -0500 Convert CONFIG_MTD_PARTITIONS et al to Kconfig =20 This converts the following to Kconfig: CONFIG_MTD_PARTITIONS CONFIG_MTD_DEVICE =20 Signed-off-by: Adam Ford And indeed I saw the double entry when I rebased and removed the duplicate. So yes, you can drop this one, and I will drop the unneeded patch in the "Clean MTD partition..." series. Good catch! Miqu=C3=A8l