From: Adam Ford <aford173@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] ARM: omap3_logic: Remove Torpedo/SOM-LV autodection
Date: Sun, 9 Sep 2018 15:24:05 -0500 [thread overview]
Message-ID: <20180909202405.12410-5-aford173@gmail.com> (raw)
In-Reply-To: <20180909202405.12410-1-aford173@gmail.com>
With there now being four device tree files, and 4 separate
defconfig files, the code necessary to determine which board is
being used is no longer necessary as the corresponding pin-muxing
and board names are determined by the device tree.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/board/logicpd/omap3som/omap3logic.c b/board/logicpd/omap3som/omap3logic.c
index 620423bbc8..6054ed8739 100644
--- a/board/logicpd/omap3som/omap3logic.c
+++ b/board/logicpd/omap3som/omap3logic.c
@@ -70,40 +70,6 @@ U_BOOT_DEVICE(am335x_mmc0) = {
#endif
-/*
- * two dimensional array of strucures containining board name and Linux
- * machine IDs; row it selected based on CPU column is slected based
- * on hsusb0_data5 pin having a pulldown resistor
- */
-static struct board_id {
- char *name;
- int machine_id;
- char *fdtfile;
-} boards[2][2] = {
- {
- {
- .name = "OMAP35xx SOM LV",
- .machine_id = MACH_TYPE_OMAP3530_LV_SOM,
- .fdtfile = "logicpd-som-lv-35xx-devkit.dtb",
- },
- {
- .name = "OMAP35xx Torpedo",
- .machine_id = MACH_TYPE_OMAP3_TORPEDO,
- .fdtfile = "logicpd-torpedo-35xx-devkit.dtb",
- },
- },
- {
- {
- .name = "DM37xx SOM LV",
- .fdtfile = "logicpd-som-lv-37xx-devkit.dtb",
- },
- {
- .name = "DM37xx Torpedo",
- .fdtfile = "logicpd-torpedo-37xx-devkit.dtb",
- },
- },
-};
-
#ifdef CONFIG_SPL_OS_BOOT
int spl_start_uboot(void)
{
@@ -226,7 +192,6 @@ int ehci_hcd_stop(int index)
#endif /* CONFIG_USB_EHCI_HCD */
-
/*
* Routine: misc_init_r
* Description: Configure board specific parts
@@ -243,11 +208,6 @@ int misc_init_r(void)
return 0;
}
-/*
- * BOARD_ID_GPIO - GPIO of pin with optional pulldown resistor on SOM LV
- */
-#define BOARD_ID_GPIO 189 /* hsusb0_data5 pin */
-
/*
* Routine: board_init
* Description: Early hardware init.
@@ -275,54 +235,6 @@ static void unlock_nand(void)
int board_late_init(void)
{
- struct board_id *board;
- unsigned int val;
-
- /*
- * To identify between a SOM LV and Torpedo module,
- * a pulldown resistor is on hsusb0_data5 for the SOM LV module.
- * Drive the pin (and let it soak), then read it back.
- * If the pin is still high its a Torpedo. If low its a SOM LV
- */
-
- /* Mux hsusb0_data5 as a GPIO */
- MUX_VAL(CP(HSUSB0_DATA5), (IEN | PTD | DIS | M4));
-
- if (gpio_request(BOARD_ID_GPIO, "husb0_data5.gpio_189") == 0) {
-
- /*
- * Drive BOARD_ID_GPIO - the pulldown resistor on the SOM LV
- * will drain the voltage.
- */
- gpio_direction_output(BOARD_ID_GPIO, 0);
- gpio_set_value(BOARD_ID_GPIO, 1);
-
- /* Let it soak for a bit */
- sdelay(0x100);
-
- /*
- * Read state of BOARD_ID_GPIO as an input and if its set.
- * If so the board is a Torpedo
- */
- gpio_direction_input(BOARD_ID_GPIO);
- val = gpio_get_value(BOARD_ID_GPIO);
- gpio_free(BOARD_ID_GPIO);
-
- board = &boards[!!(get_cpu_family() == CPU_OMAP36XX)][!!val];
- printf("Board: %s\n", board->name);
-
- /* Set the machine_id passed to Linux */
- if (board->machine_id)
- gd->bd->bi_arch_number = board->machine_id;
-
- /* If the user has not set fdtimage, set the default */
- if (!env_get("fdtimage"))
- env_set("fdtimage", board->fdtfile);
- }
-
- /* restore hsusb0_data5 pin as hsusb0_data5 */
- MUX_VAL(CP(HSUSB0_DATA5), (IEN | PTD | DIS | M0));
-
#ifdef CONFIG_CMD_NAND_LOCK_UNLOCK
unlock_nand();
#endif
@@ -363,5 +275,3 @@ int board_eth_init(bd_t *bis)
return smc911x_initialize(0, CONFIG_SMC911X_BASE);
}
#endif
-
-
diff --git a/include/configs/omap3_logic.h b/include/configs/omap3_logic.h
index 2cbdbebb26..8644e16830 100644
--- a/include/configs/omap3_logic.h
+++ b/include/configs/omap3_logic.h
@@ -116,6 +116,7 @@
"ip=${ipaddr}:${tftpserver}:${gatewayip}:${netmask}::eth0:off\0" \
"nfsrootpath=/opt/nfs-exports/omap\0" \
"autoload=no\0" \
+ "fdtimage=" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \
"loadfdt=mmc rescan; " \
"load mmc ${mmcdev} ${fdtaddr} ${fdtimage}\0" \
"mmcbootcommon=echo Booting with DT from mmc${mmcdev} ...; " \
--
2.17.1
prev parent reply other threads:[~2018-09-09 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 20:24 [U-Boot] [PATCH 1/5] ARM: dts: omap36xx-u-boot.dtsi Adam Ford
2018-09-09 20:24 ` [U-Boot] [PATCH 2/5] ARM: DTS: logicpd-som-lv-37xx-devkit-u-boot Adam Ford
2018-09-09 20:24 ` [U-Boot] [PATCH 3/5] configs: ARM: Add omap36_logic_somlv_defconfig Adam Ford
2018-09-09 20:24 ` [U-Boot] [PATCH 4/5] configs: ARM: Add omap35_logic_somlv_defconfig Adam Ford
2018-09-09 20:24 ` Adam Ford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180909202405.12410-5-aford173@gmail.com \
--to=aford173@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox