U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] fdt: fix get_next_memory_node()
Date: Mon, 10 Sep 2018 17:49:12 -0400	[thread overview]
Message-ID: <20180910214912.GH4980@bill-the-cat> (raw)
In-Reply-To: <20180909143011.4001-1-marek.vasut+renesas@gmail.com>

On Sun, Sep 09, 2018 at 04:30:11PM +0200, Marek Vasut wrote:

> The get_next_memory_node() always sets mem to -1 , which is incorrect,
> because then every iteration of memory bank parsing will start from the
> first memory bank instead of the previous one.
> 
> On systems with 1 memory bank defined in DT and CONFIG_NR_DRAM_BANKS=4 ,
> like ie. r8a77965-salvator-x , this will result in U-Boot incorrectly
> reporting four identical memory banks with the same memory configuration.
> 
> Fix this by setting mem to startoffset value, which restores the behavior
> before the fixed patch was applied.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Jens Wiklander <jens.wiklander@linaro.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Fixes: 452bc121027d ("fdt: fix fdtdec_setup_memory_banksize()")
> Tested-by: Michal Simek <michal.simek@xilinx.com> [on ZynqMP}

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180910/aba7698e/attachment.sig>

      parent reply	other threads:[~2018-09-10 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09 14:30 [U-Boot] [PATCH] fdt: fix get_next_memory_node() Marek Vasut
2018-09-10 11:23 ` Michal Simek
2018-09-10 11:27   ` Marek Vasut
2018-09-10 12:45     ` Michal Simek
2018-09-10 21:49 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910214912.GH4980@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox