U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/2] Makefile: Use -fno-strict-aliasing globally
Date: Mon, 10 Sep 2018 17:49:33 -0400	[thread overview]
Message-ID: <20180910214933.GK4980@bill-the-cat> (raw)
In-Reply-To: <1536587626-3664-1-git-send-email-bmeng.cn@gmail.com>

On Mon, Sep 10, 2018 at 06:53:45AM -0700, Bin Meng wrote:

> The -fstrict-aliasing option is implicitly enabled at levels -O2,
> -O3, -Os by GCC. This option allows the compiler to assume the
> strictest aliasing rules applicable to the language being compiled.
> For example, the practice of reading from a different union member
> than the one most recently written to (called "type-punning") is
> common. In this case, "type-punning" only works if the memory is
> accessed through the union type, but might not work by taking the
> address, casting the resulting pointer and dereferencing the result,
> which is an undefined behavior per the "strict aliasing rules".
> 
> GCC's -Wstrict-aliasing (included in -Wall) option does not catch
> all cases, but does attempt to catch the more common pitfalls. So
> there are cases that GCC does not report but the codes are violating
> the "strict aliasing rules".
> 
> Given lots of codes that may be written to rely on "type-punning",
> and Linux kernel disables it by -fno-strict-aliasing globally, since
> U-Boot currently does this on nds32/riscv/x86 builds only, extend
> this for all architecture builds.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180910/c67bfe13/attachment.sig>

  parent reply	other threads:[~2018-09-10 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 13:53 [U-Boot] [RFC PATCH 1/2] Makefile: Use -fno-strict-aliasing globally Bin Meng
2018-09-10 13:53 ` [U-Boot] [RFC PATCH 2/2] config.mk: Remove duplicated -fno-strict-aliasing Bin Meng
     [not found]   ` <752D002CFF5D0F4FA35C0100F1D73F3F6BCBEC7A@ATCPCS16.andestech.com>
2018-09-11  1:54     ` Rick Chen
2018-09-10 21:49 ` Tom Rini [this message]
2018-09-14 10:53 ` [U-Boot] [RFC PATCH 1/2] Makefile: Use -fno-strict-aliasing globally Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910214933.GK4980@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox