From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akashi, Takahiro Date: Wed, 12 Sep 2018 09:53:40 +0900 Subject: [U-Boot] [PATCH v3 01/26] fs: fat: guard the content of include/fat.h In-Reply-To: References: <20180911065922.19141-1-takahiro.akashi@linaro.org> <20180911065922.19141-2-takahiro.akashi@linaro.org> Message-ID: <20180912005338.GK30795@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Sep 11, 2018 at 12:12:53PM +0200, Alexander Graf wrote: > > > On 11.09.18 08:58, Akashi, Takahiro wrote: > > From: AKASHI Takahiro > > > > The whole content of include/fat.h is private to FAT implementation > > and then should be guarded with CONFIG_FS_FAT. > > > > Signed-off-by: AKASHI Takahiro > > I thought we could drop this patch now? No, we can't as I said in https://lists.denx.de/pipermail/u-boot/2018-September/340233.html > If you really need it, please state why in the patch description and Oops, I've forgot to do so. > make sure to include common.h before you do the #ifdef on CONFIG_FS_FAT. > Otherwise the symbol might not be declared. Forgot it, too :) Can I re-submit only this patch(01/26) rather than my whole patch set? -Takahiro Akashi > Alex > > > --- > > include/fat.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/fat.h b/include/fat.h > > index 09e142368585..c02839dcb040 100644 > > --- a/include/fat.h > > +++ b/include/fat.h > > @@ -9,6 +9,8 @@ > > #ifndef _FAT_H_ > > #define _FAT_H_ > > > > +#ifdef CONFIG_FS_FAT > > + > > #include > > #include > > > > @@ -202,4 +204,5 @@ int fat_opendir(const char *filename, struct fs_dir_stream **dirsp); > > int fat_readdir(struct fs_dir_stream *dirs, struct fs_dirent **dentp); > > void fat_closedir(struct fs_dir_stream *dirs); > > void fat_close(void); > > +#endif /* CONFIG_FS_FAT */ > > #endif /* _FAT_H_ */ > >