From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 13/13] configs: sandbox*: Enable UBSAN
Date: Mon, 17 Sep 2018 23:10:06 +0200 [thread overview]
Message-ID: <20180917211006.GA4503@x230> (raw)
In-Reply-To: <CAPnjgZ0zBBXKOCbk8zHUoAght2xPYViaWi5pR7qQgARM_E4_AA@mail.gmail.com>
Hi Simon,
On Wed, Aug 29, 2018 at 08:51:24PM -0600, Simon Glass wrote:
> Hi,
>
> On 26 August 2018 at 17:13, Eugeniu Rosca <roscaeugeniu@gmail.com> wrote:
> > On Sun, Aug 19, 2018 at 09:51:32PM -0400, Tom Rini wrote:
> >> [..] we should be able to say more broadly that just about everyone
> >> can enable this, but only out of the box sandbox should.
> >
> > Hence, turn UBSAN on for every available sandbox flavor.
> > Make sure the inserted line complies with `make savedefconfig`.
> >
> > The size increase of sandbox_defconfig U-Boot (gcc 8.1.0):
> > $ size u-boot.sandbox.*
> > text data bss dec hex filename
> > 1234958 80048 291472 1606478 18834e u-boot.sandbox.default
> > 1422710 272240 291472 1986422 1e4f76 u-boot.sandbox.ubsan
> > +187752 +192192 0 +379944
> >
> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> > ---
> >
> > Changes in v2:
> > - None. Newly pushed.
> > ---
> > configs/sandbox64_defconfig | 1 +
> > configs/sandbox_defconfig | 1 +
> > configs/sandbox_flattree_defconfig | 1 +
> > configs/sandbox_noblk_defconfig | 1 +
> > configs/sandbox_spl_defconfig | 1 +
> > 5 files changed, 5 insertions(+)
> >
>
> Can you please do this with an 'imply' in arch/Kconfig?
Thanks for your review comment. I will incorporate the change in the
next patch revision, once we clarify how to deal with the "left-shifting
of 1 into the sign bit" UBSAN warnings, which is being discussed in
https://patchwork.ozlabs.org/patch/962305/#1991283 .
> Regards,
> Simon
Regards,
Eugeniu.
prev parent reply other threads:[~2018-09-17 21:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 23:13 [U-Boot] [PATCH v2 00/13] Import Undefined Behavior Sanitizer Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 01/13] UBSAN: run-time undefined behavior sanity checker Eugeniu Rosca
2018-08-27 14:13 ` Tom Rini
2018-08-26 23:13 ` [U-Boot] [PATCH v2 02/13] mmc: Fix signed shift overflow Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 03/13] armv8: mmu: " Eugeniu Rosca
2018-08-27 14:13 ` Tom Rini
2018-08-26 23:13 ` [U-Boot] [PATCH v2 04/13] pinctrl: renesas: " Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 05/13] net: phy: " Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 06/13] net: ravb: " Eugeniu Rosca
2018-08-26 23:22 ` Marek Vasut
2018-08-27 20:24 ` Eugeniu Rosca
2018-08-27 23:55 ` Marek Vasut
2018-08-26 23:13 ` [U-Boot] [PATCH v2 07/13] x86: Fix signed shift overflow in MSR_IA32_APICBASE_BASE Eugeniu Rosca
2018-08-28 2:05 ` Bin Meng
2018-08-28 6:42 ` Eugeniu Rosca
2018-09-01 10:59 ` Eugeniu Rosca
2018-09-04 4:00 ` Bin Meng
2018-09-16 18:46 ` Eugeniu Rosca
2018-09-22 23:10 ` Eugeniu Rosca
2018-09-25 2:06 ` Bin Meng
2018-10-09 0:22 ` Eugeniu Rosca
2018-08-28 8:14 ` Andy Shevchenko
2018-08-26 23:13 ` [U-Boot] [PATCH v2 08/13] disk: part_dos: Fix signed shift overflow Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 09/13] common.h: Fix signed shift overflow in cpumask_next() Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 10/13] mmc: Fix read-past-end-of-array Eugeniu Rosca
2018-08-26 23:13 ` [U-Boot] [PATCH v2 11/13] hashtable: Fix zero-sized array Eugeniu Rosca
2018-08-27 14:13 ` Tom Rini
2018-08-26 23:13 ` [U-Boot] [PATCH v2 12/13] input: " Eugeniu Rosca
2018-08-27 14:13 ` Tom Rini
2018-08-26 23:13 ` [U-Boot] [PATCH v2 13/13] configs: sandbox*: Enable UBSAN Eugeniu Rosca
2018-08-30 2:51 ` Simon Glass
2018-09-17 21:10 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917211006.GA4503@x230 \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox