From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] DM: GPIO: Fix da8xx GPIO indexing over GPIO 32
Date: Tue, 18 Sep 2018 17:23:58 -0400 [thread overview]
Message-ID: <20180918212358.GD4642@opus> (raw)
In-Reply-To: <20180817041334.21637-1-aford173@gmail.com>
On Thu, Aug 16, 2018 at 11:13:34PM -0500, Adam Ford wrote:
> The GPIO banks are broken up into two 16-bit registers for each
> bank set. Unfortunately, the math that determines how to shift
> blindly shifted by the number of the gpio. This worked for gpio
> numbers under 32, but higher gpio's are broken. This fixes the
> gpio index, so the bank is passed and the shift amount within
> the register is passed now instead of the gpio number.
>
> Fixes: 8e51c0f25406("dm: gpio: Add DM compatibility to
> GPIO driver for Davinci")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/drivers/gpio/da8xx_gpio.c b/drivers/gpio/da8xx_gpio.c
> index 1a1d37ae2a..3e95f039f0 100644
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180918/1fd9fe04/attachment.sig>
prev parent reply other threads:[~2018-09-18 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 4:13 [U-Boot] [PATCH] DM: GPIO: Fix da8xx GPIO indexing over GPIO 32 Adam Ford
2018-09-18 21:23 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918212358.GD4642@opus \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox