[U-Boot] [PATCH] DM: serial: ti_omap3_common: Don't define serial unless !DM_SERIAL

[U-Boot] [PATCH] DM: serial: ti_omap3_common: Don't define serial unless !DM_SERIAL

[Adam Ford]

The serial port was being manually configured during SPL build,
however in preparation to allow DM in SPL, this needs to change
to be based on whether or not DM_SERIAL is enabled because, soon
the assumption that SPL means no DM may not be accurate.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
index dcf76305db..c668284b3e 100644
--- a/include/configs/ti_omap3_common.h
+++ b/include/configs/ti_omap3_common.h
@@ -27,12 +27,10 @@
 /* NS16550 Configuration */
 #define V_NS16550_CLK			48000000	/* 48MHz (APLL96/2) */
 #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
-#if defined(CONFIG_SPL_BUILD)
-#define CONFIG_SYS_NS16550_SERIAL
 #if !defined(CONFIG_DM_SERIAL)
+#define CONFIG_SYS_NS16550_SERIAL
 #define CONFIG_SYS_NS16550_REG_SIZE	(-4)
 #endif /* !CONFIG_DM_SERIAL */
-#endif /* CONFIG_SPL_BUILD */
 #define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600, \
 					115200}
 
-- 
2.17.1

[U-Boot] [PATCH] DM: serial: ti_omap3_common: Don't define serial unless !DM_SERIAL

[Simon Glass]

On 20 August 2018 at 19:43, Adam Ford <aford173@gmail.com> wrote:
> The serial port was being manually configured during SPL build,
> however in preparation to allow DM in SPL, this needs to change
> to be based on whether or not DM_SERIAL is enabled because, soon
> the assumption that SPL means no DM may not be accurate.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] DM: serial: ti_omap3_common: Don't define serial unless !DM_SERIAL

[Tom Rini]

On Mon, Aug 20, 2018 at 08:43:00PM -0500, Adam Ford wrote:

> The serial port was being manually configured during SPL build,
> however in preparation to allow DM in SPL, this needs to change
> to be based on whether or not DM_SERIAL is enabled because, soon
> the assumption that SPL means no DM may not be accurate.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
> index dcf76305db..c668284b3e 100644

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180918/dfcc5619/attachment.sig>