public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 01/13] ehci: Replace board_prepare_usb with board_usb_init
Date: Wed, 19 Sep 2018 21:28:09 +0300	[thread overview]
Message-ID: <20180919182821.19575-2-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180919182821.19575-1-ramon.fried@gmail.com>

Use standard board_usb_init() instead of the specific board_prepare_usb.

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>

---

 board/qualcomm/dragonboard410c/dragonboard410c.c | 4 ++--
 drivers/usb/host/ehci-msm.c                      | 9 ++-------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c
index 53e231e55a..e8a3ed0450 100644
--- a/board/qualcomm/dragonboard410c/dragonboard410c.c
+++ b/board/qualcomm/dragonboard410c/dragonboard410c.c
@@ -44,7 +44,7 @@ int dram_init_banksize(void)
 	return 0;
 }
 
-int board_prepare_usb(enum usb_init_type type)
+int board_usb_init(int index, enum usb_init_type init)
 {
 	static struct udevice *pmic_gpio;
 	static struct gpio_desc hub_reset, usb_sel;
@@ -93,7 +93,7 @@ int board_prepare_usb(enum usb_init_type type)
 		}
 	}
 
-	if (type == USB_INIT_HOST) {
+	if (init == USB_INIT_HOST) {
 		/* Start USB Hub */
 		dm_gpio_set_dir_flags(&hub_reset,
 				      GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
index 17bfa7c02f..db982624dc 100644
--- a/drivers/usb/host/ehci-msm.c
+++ b/drivers/usb/host/ehci-msm.c
@@ -38,11 +38,6 @@ struct msm_ehci_priv {
 	struct ulpi_viewport ulpi_vp; /* ULPI Viewport */
 };
 
-int __weak board_prepare_usb(enum usb_init_type type)
-{
-	return 0;
-}
-
 static void setup_usb_phy(struct msm_ehci_priv *priv)
 {
 	/* Select and enable external configuration with USB PHY */
@@ -102,7 +97,7 @@ static int ehci_usb_probe(struct udevice *dev)
 	hcor = (struct ehci_hcor *)((phys_addr_t)hccr +
 			HC_LENGTH(ehci_readl(&(hccr)->cr_capbase)));
 
-	ret = board_prepare_usb(USB_INIT_HOST);
+	ret = board_usb_init(0, USB_INIT_HOST);
 	if (ret < 0)
 		return ret;
 
@@ -124,7 +119,7 @@ static int ehci_usb_remove(struct udevice *dev)
 
 	reset_usb_phy(p);
 
-	ret = board_prepare_usb(USB_INIT_DEVICE); /* Board specific hook */
+	ret = board_usb_init(0, USB_INIT_DEVICE); /* Board specific hook */
 	if (ret < 0)
 		return ret;
 
-- 
2.18.0

  reply	other threads:[~2018-09-19 18:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 18:28 [U-Boot] [PATCH v1 00/13] Introduce fastboot support for dragonboard410c Ramon Fried
2018-09-19 18:28 ` Ramon Fried [this message]
2018-09-19 18:28 ` [U-Boot] [PATCH v1 02/13] ehci: msm: Add missing platdata Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 03/13] dts: db410c: add alias for USB Ramon Fried
2018-09-19 19:28   ` Peter Robinson
2018-09-19 19:32     ` Ramon Fried
2018-09-19 20:03       ` Peter Robinson
2018-09-19 18:28 ` [U-Boot] [PATCH v1 04/13] db410c: serial# env using msm board serial Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 05/13] phy: db410c: Add MSM USB PHY driver Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 06/13] dts: db410c: Add bindings for MSM USB phy Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 07/13] configs: db410c: Enable USB PHY Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 08/13] ehci: msm: switch to generic PHY uclass Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 09/13] ehci: msm: use init_type in probe Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 10/13] usb:ci_udc: Introduce init_after_reset phy function Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 11/13] usb: ehci-msm: Add init_after_reset for CI_UDC Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 12/13] DB410c: Enable fastboot support Ramon Fried
2018-09-19 18:28 ` [U-Boot] [PATCH v1 13/13] db410c: automatically launch fastboot Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919182821.19575-2-ramon.fried@gmail.com \
    --to=ramon.fried@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox