From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akashi, Takahiro <takahiro.akashi@linaro.org>
Date: Tue, 25 Sep 2018 13:54:47 +0900
Subject: [U-Boot] [PATCH v3.1 01/26] fs: fat: guard the content of
	include/fat.h
In-Reply-To: <d383f175-acae-ccb6-c93a-481e124d69f1@suse.de>
References: <20180911065922.19141-2-takahiro.akashi@linaro.org>
 <20180912065541.6251-1-takahiro.akashi@linaro.org>
 <d383f175-acae-ccb6-c93a-481e124d69f1@suse.de>
Message-ID: <20180925045445.GB27322@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun, Sep 23, 2018 at 04:42:17PM +0200, Alexander Graf wrote:
> 
> 
> On 12.09.18 08:55, Akashi, Takahiro wrote:
> > From: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > 
> > The whole content of include/fat.h should be guarded with CONFIG_FS_FAT.
> > 
> > This is necessary specifically because fs/fs.c unconditionally includes
> > fat.h, which refers to a config symbol, CONFIG_FS_FAT_MAX_CLUSTSIZE.
> > So if CONFIG_FS_FAT, and thus CONFIG_FS_FAT_MAX_CLUSTSIZE, is not
> > defined, fs/fs.c will fail to compile.
> 
> I don't see that define used anywhere outside of FAT code, so I still
> don't understand why we need this patch.

Try to compile u-boot without CONFIG_FS_FAT.
You will find out what I (and originally Heinrich) meant.

Thanks,
-Takahiro Akashi

> 
> Alex