From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/8] Improvements for the dwc3_generic driver
Date: Tue, 25 Sep 2018 13:28:14 +0200 [thread overview]
Message-ID: <20180925132814.583a822b@jawa> (raw)
In-Reply-To: <1537866203-7717-1-git-send-email-jjhiblot@ti.com>
Dear All,
> This series aims at bringing improvements to the dwc3_generic driver
> so that it can be used by most of the platforms using the dwc3
> controller.
>
> I tested this on with DRA7 and AM57x platforms for both Peripheral
> and Host operations. The code to enable DM USB host & dev support for
> those platforms will be submitted in a separate series.
>
> Michal Simek has tested this series:
> " I have tested it on zcu100 with usb stick, usb to ethernet
> converter and also dfu.
> Tested-by: Michal Simek <michal.simek@xilinx.com>"
>
> Enhancements:
> - use separate Kconfig option for DM USB Periphal and DM USB Host.
> This allow platforms to keep their non-DM USB peripheral code and use
> the DM USB host.
> - fixes the bind/probe confusion in dwc3_generic. The probe is done
> when the USB device is first needed.
> - handles PHYs when in the peripheral mode. The code to handle the
> PHYs is shared with the host side
> - handles clock and reset
> - bind host controller to the more generic driver 'xhci-dwc3'
>
>
> Changes in v3:
> - fixes bug dwc3_setup_phy(): the phy arrays wasn't returned. This was
> visible only when the device is removed.
> - Stub the DWC3 PHY operations if CONFIG_IS_ENABLED(PHY) is false.
> This fixes all build issues but one (evb-rk3328).
> - Fix build issue with evb-rk3328 by enabling CONFIG_USB_DWC3. This
> has little impact on the footprint and should not break the runtime
> as the xhci-rockchip driver has its own probe function.
> Nevertheless this was !!! NOT TESTED !!! by lack of hw
Can somebody test this patch set on rk3328 and provide Tested-by tag?
>
> Changes in v2:
> - Updated commit log
> - Fixed typo in thordown.c
> - select DM_USB_DEV by default for zynqmp platforms
>
> Jean-Jacques Hiblot (8):
> usb: gadget: Do not call board_usb_xxx() directly in USB gadget
> drivers
> usb: introduce a separate config option for DM USB device
> usb: udc: implement DM versions of
> usb_gadget_initialize()/_release()/_handle_interrupt()
> dwc3_generic: do not probe the USB device driver when it's bound
> dwc3: move phy operation to core.c
> configs: evb-rk3328: Enable CONFIG_USB_DWC3
> dwc3-generic: Handle the PHYs, the clocks and the reset lines
> dwc3-generic: Add select_dr_mode operation
>
> arch/arm/Kconfig | 2 +
> cmd/fastboot.c | 4 +-
> cmd/rockusb.c | 4 +-
> cmd/thordown.c | 4 +-
> cmd/usb_gadget_sdp.c | 4 +-
> cmd/usb_mass_storage.c | 4 +-
> common/dfu.c | 6 +-
> configs/evb-rk3328_defconfig | 1 +
> drivers/usb/Kconfig | 6 ++
> drivers/usb/dwc3/Kconfig | 7 +-
> drivers/usb/dwc3/core.c | 89 +++++++++++++++-
> drivers/usb/dwc3/dwc3-generic.c | 207
> +++++++++++++++++++++++++++++---------
> drivers/usb/dwc3/ep0.c | 1 -
> drivers/usb/gadget/ether.c | 38 +------
> drivers/usb/gadget/udc/udc-core.c | 44 +++++++-
> drivers/usb/host/xhci-dwc3.c | 95 ++---------------
> include/dwc3-uboot.h | 19 ++++
> include/linux/usb/gadget.h | 18 ++++ 18 files changed, 367
> insertions(+), 186 deletions(-)
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180925/79b10720/attachment.sig>
next prev parent reply other threads:[~2018-09-25 11:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 9:03 [U-Boot] [PATCH v3 0/8] Improvements for the dwc3_generic driver Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 1/8] usb: gadget: Do not call board_usb_xxx() directly in USB gadget drivers Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 2/8] usb: introduce a separate config option for DM USB device Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 3/8] usb: udc: implement DM versions of usb_gadget_initialize()/_release()/_handle_interrupt() Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 4/8] dwc3_generic: do not probe the USB device driver when it's bound Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 5/8] dwc3: move phy operation to core.c Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 6/8] configs: evb-rk3328: Enable CONFIG_USB_DWC3 Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 7/8] dwc3-generic: Handle the PHYs, the clocks and the reset lines Jean-Jacques Hiblot
2018-09-25 9:03 ` [U-Boot] [PATCH v3 8/8] dwc3-generic: Add select_dr_mode operation Jean-Jacques Hiblot
2018-09-25 11:28 ` Lukasz Majewski [this message]
2018-10-01 12:51 ` [U-Boot] [PATCH v3 0/8] Improvements for the dwc3_generic driver Lukasz Majewski
2018-10-01 13:26 ` Philipp Tomsich
2018-10-08 2:07 ` Kever Yang
2018-10-22 10:45 ` Jean-Jacques Hiblot
2018-10-09 14:29 ` Loic Devulder
2018-10-22 15:55 ` Jean-Jacques Hiblot
2018-10-22 16:16 ` Lukasz Majewski
2018-10-22 16:24 ` Jean-Jacques Hiblot
2018-10-26 10:25 ` Jean-Jacques Hiblot
2018-10-28 20:50 ` Lukasz Majewski
2018-11-01 9:27 ` Michal Simek
2018-11-01 15:56 ` Lukasz Majewski
2018-11-01 16:06 ` Tom Rini
2018-11-01 16:55 ` Lukasz Majewski
2018-11-16 14:49 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925132814.583a822b@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox