[U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup

Lukasz Majewski
2018-10-01T12:50:09Z

Hi Ramon,

> change writel to writebits32 in ci_pullup() in order
> to keep phy configuration in tact.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> ---
>
> Changes in v2:
> Patch introduced
>
> drivers/usb/gadget/ci_udc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index 8d23fab3b7..0a84f6850d 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -906,7 +906,8 @@ static int ci_pullup(struct usb_gadget *gadget,
> int is_on) writel(0xffffffff, &udc->epflush);
>
> /* Turn on the USB connection by enabling the pullup
> resistor */
> - writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RUN,
> &udc->usbcmd);
> + setbits_le32(&udc->usbcmd, USBCMD_ITC(MICRO_8FRAME) |
> + USBCMD_RUN);
> } else {
> udc_disconnect();
> }

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181001/415d4b89/attachment.sig>