From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup
Date: Mon, 1 Oct 2018 14:50:09 +0200 [thread overview]
Message-ID: <20181001145009.41a9b7a4@jawa> (raw)
In-Reply-To: <20180921103555.16240-15-ramon.fried@gmail.com>
Hi Ramon,
> change writel to writebits32 in ci_pullup() in order
> to keep phy configuration in tact.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> ---
>
> Changes in v2:
> Patch introduced
>
> drivers/usb/gadget/ci_udc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index 8d23fab3b7..0a84f6850d 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -906,7 +906,8 @@ static int ci_pullup(struct usb_gadget *gadget,
> int is_on) writel(0xffffffff, &udc->epflush);
>
> /* Turn on the USB connection by enabling the pullup
> resistor */
> - writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RUN,
> &udc->usbcmd);
> + setbits_le32(&udc->usbcmd, USBCMD_ITC(MICRO_8FRAME) |
> + USBCMD_RUN);
> } else {
> udc_disconnect();
> }
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181001/415d4b89/attachment.sig>
prev parent reply other threads:[~2018-10-01 12:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:35 [U-Boot] [PATCH v2 00/14] Introduce fastboot support for dragonboard410c Ramon Fried
2018-09-21 10:35 ` [U-Boot] [PATCH v2 01/14] ehci: Replace board_prepare_usb with board_usb_init Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 02/14] ehci: msm: Add missing platdata Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot,v2,02/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 03/14] dts: db410c: add alias for USB Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot,v2,03/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 04/14] db410c: serial# env using msm board serial Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 05/14] phy: db410c: Add MSM USB PHY driver Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot,v2,05/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 06/14] dts: db410c: Add bindings for MSM USB phy Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 07/14] configs: db410c: Enable USB PHY Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot,v2,07/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 08/14] ehci: msm: switch to generic PHY uclass Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 09/14] ehci: msm: use init_type in probe Ramon Fried
2018-09-30 19:25 ` [U-Boot] [U-Boot,v2,09/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 10/14] usb:ci_udc: Introduce init_after_reset phy function Ramon Fried
2018-09-30 19:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-10-01 12:49 ` [U-Boot] [PATCH v2 " Lukasz Majewski
2018-09-21 10:35 ` [U-Boot] [PATCH v2 11/14] usb: ehci-msm: Add init_after_reset for CI_UDC Ramon Fried
2018-09-30 19:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 12/14] DB410c: Enable fastboot support Ramon Fried
2018-09-30 19:26 ` [U-Boot] [U-Boot,v2,12/14] " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 13/14] db410c: automatically launch fastboot Ramon Fried
2018-09-30 19:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-09-21 10:35 ` [U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup Ramon Fried
2018-09-30 19:26 ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-10-01 12:50 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001145009.41a9b7a4@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox