From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 1 Oct 2018 14:50:09 +0200 Subject: [U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup In-Reply-To: <20180921103555.16240-15-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> <20180921103555.16240-15-ramon.fried@gmail.com> Message-ID: <20181001145009.41a9b7a4@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ramon, > change writel to writebits32 in ci_pullup() in order > to keep phy configuration in tact. > > Signed-off-by: Ramon Fried > --- > > Changes in v2: > Patch introduced > > drivers/usb/gadget/ci_udc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c > index 8d23fab3b7..0a84f6850d 100644 > --- a/drivers/usb/gadget/ci_udc.c > +++ b/drivers/usb/gadget/ci_udc.c > @@ -906,7 +906,8 @@ static int ci_pullup(struct usb_gadget *gadget, > int is_on) writel(0xffffffff, &udc->epflush); > > /* Turn on the USB connection by enabling the pullup > resistor */ > - writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RUN, > &udc->usbcmd); > + setbits_le32(&udc->usbcmd, USBCMD_ITC(MICRO_8FRAME) | > + USBCMD_RUN); > } else { > udc_disconnect(); > } Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: