From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v13 5/7] cmd: mtd: add 'mtd' command
Date: Mon, 8 Oct 2018 21:07:59 +0200 [thread overview]
Message-ID: <20181008210759.250b0e8a@windsurf> (raw)
In-Reply-To: <20181008194627.71352d73@bbrezillon>
Hello,
On Mon, 8 Oct 2018 19:46:27 +0200, Boris Brezillon wrote:
> > + /* Check if mtdparts/mtdids changed since last call, otherwise: exit */
> > + if (!strcmp(mtdparts, old_mtdparts) && !strcmp(mtdids, old_mtdids))
> > + return 0;
>
> Should be:
>
> if ((!mtdparts && !old_mtdparts && !mtdids && !old_mtdids) ||
If there's a || here, it means you can split the conditions into to:
if (!mtdparts && !old_mtdparts && !mtdids && !old_mtdids)
return 0;
if (mtdparts && old_mtdparts && mtdids && old_mtdids &&
!strcmp(mtdparts, old_mtdparts) &&
!strcmp(mtdids, old_mtdids)))
return 0;
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-08 19:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 13:43 [U-Boot] [PATCH v13 0/7] SPI-NAND support (third batch) Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 1/7] mtd: uclass: add probe function Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 2/7] mtd: mtdpart: add a generic mtdparts-like parser Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 3/7] mtd: uboot: search for an equivalent MTD name with the mtdids Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 4/7] mtd: mtdpart: implement proper partition handling Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 5/7] cmd: mtd: add 'mtd' command Miquel Raynal
2018-10-01 16:19 ` Jagan Teki
2018-10-01 20:39 ` Miquel Raynal
2018-10-03 12:35 ` Adam Ford
2018-10-03 12:42 ` Miquel Raynal
2018-10-03 12:47 ` Adam Ford
2018-10-03 12:57 ` Miquel Raynal
2018-10-03 13:35 ` Miquel Raynal
2018-10-03 13:41 ` Adam Ford
2018-10-08 16:13 ` Adam Ford
2018-10-08 16:28 ` Boris Brezillon
2018-10-08 16:52 ` Adam Ford
2018-10-08 16:58 ` Adam Ford
2018-10-08 17:27 ` Boris Brezillon
2018-10-08 17:46 ` Boris Brezillon
2018-10-08 18:26 ` Adam Ford
2018-10-08 19:07 ` Thomas Petazzoni [this message]
2018-10-08 19:14 ` Adam Ford
2018-10-01 13:43 ` [U-Boot] [PATCH v13 6/7] cmd: ubi: clean the partition handling Miquel Raynal
2018-10-01 13:43 ` [U-Boot] [PATCH v13 7/7] cmd: mtdparts: describe as legacy Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008210759.250b0e8a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox