public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand: atmel: Initialize pmecc smu with correct size
Date: Tue, 9 Oct 2018 09:47:33 +0200	[thread overview]
Message-ID: <20181009094733.695674d3@xps13> (raw)
In-Reply-To: <1538990864-26421-1-git-send-email-bmeng.cn@gmail.com>

Hi Bin,

Bin Meng <bmeng.cn@gmail.com> wrote on Mon,  8 Oct 2018 02:27:44 -0700:

> Currently in pmecc_get_sigma(), the code tries to clear the memory
> pointed by smu with wrong size 'sizeof(int16_t) * ARRAY_SIZE(smu)'.
> Since smu is actually a pointer, not an array, so ARRAY_SIZE(smu)
> does not generate correct size to be cleared.
> 
> In fact, GCC 8.1.0 reports a warning against it:
> 
> error: division 'sizeof (int16_t * {aka short int *}) / sizeof (int16_t
> {aka short int})' does not compute the number of array elements
> [-Werror=sizeof-pointer-div]
> 
> Fix it by using the correct size.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 

It's curious that the code of this driver differs a lot from its Linux
cousin. Anyway this looks fine by me. Maybe a Fixes tag would be
great.

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

  reply	other threads:[~2018-10-09  7:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  9:27 [U-Boot] [PATCH] nand: atmel: Initialize pmecc smu with correct size Bin Meng
2018-10-09  7:47 ` Miquel Raynal [this message]
2018-10-22 10:06   ` Bin Meng
2018-10-22 17:25 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009094733.695674d3@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox