From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Sun, 14 Oct 2018 10:44:35 +0200
Subject: [U-Boot] [PATCH V5 08/32] misc: add i.MX8 misc driver
In-Reply-To: <20180926135256.2098-9-peng.fan@nxp.com>
References: <20180926135256.2098-1-peng.fan@nxp.com>
 <20180926135256.2098-9-peng.fan@nxp.com>
Message-ID: <20181014104435.5aed85d9@crub>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Peng,

On Wed, 26 Sep 2018 21:52:32 +0800
Peng Fan peng.fan at nxp.com wrote:

> Add i.MX8 MISC driver to handle the communication between
> A35 Core and SCU.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Anatolij Gustschin <agust@denx.de>

Looks good, please see some minor comment below.

...
> +static int imx8_scu_bind(struct udevice *dev)
> +{
> +	struct imx8_scu *priv = dev_get_priv(dev);
> +	int ret;
> +	struct udevice *child;
> +	int node;
> +
> +	debug("%s(dev=%p)\n", __func__, dev);
> +
> +	node = fdt_node_offset_by_compatible(gd->fdt_blob, -1,
> +					     "fsl,imx8qxp-clk");
> +	if (node < 0)
> +		panic("No clk node found\n");
> +
> +	ret = lists_bind_fdt(dev, offset_to_ofnode(node), &child);
> +	if (ret)
> +		return ret;
> +
> +	priv->clk = child;
> +
> +	node = fdt_node_offset_by_compatible(gd->fdt_blob, -1,
> +					     "fsl,imx8qxp-iomuxc");
> +	if (node < 0)
> +		panic("No clk node found\n");

"No clk ..." is wrong here, a copy-paste reminder, it seems.
Please add "No iomuxc ..." here.

Thanks,

Anatolij