From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] sunxi: DT: A64: update device tree file for Allwinner A64 SoC
Date: Wed, 17 Oct 2018 17:54:19 +0100 [thread overview]
Message-ID: <20181017175419.009550b8@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20181017152958.r6q2ankqmkwklw5i@flea>
On Wed, 17 Oct 2018 17:29:58 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:
Hi,
> On Wed, Oct 17, 2018 at 04:18:41PM +0100, Andre Przywara wrote:
> > On Tue, 16 Oct 2018 22:09:30 -0700
> > Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> >
> > Hi,
> >
> > > Updates the device tree file from the the Linux tree as of
> > > v4.19-rc4, exactly Linux commit:
> >
> > Does this work easily without syncing the .dts files as well?
> >
> > > commit 7876320f8880 (tag: v4.19-rc4)
> > > Author: Linus Torvalds <torvalds@linux-foundation.org>
> > > Date: Sun Sep 16 11:52:37 2018 -0700
> > >
> > > Linux 4.19-rc4
> >
> > So this sounds like the right thing to do, but in this particular
> > case breaks Ethernet with UEFI booting in all distribution
> > installers or kernels out there (except >= Linux 4.19-rc1).
> > I consider this a major use case of U-Boot's DTB, so what do we do
> > about this?
> > The reason is that we dropped the "syscon" compatible string at the
> > end of the system-controller node, which older kernels rely on to
> > find the syscon node.
> > I suggested to re-add this[1], but didn't have much success,
> > unfortunately.
> > The easiest would be to re-add (or not remove) "syscon" for U-Boot's
> > copy, but this would mean a deviation from the Linux DT's. I am fine
> > with this, but would like to hear more opinions.
>
> tl; dr: You want to build something robust on top of assumptions that
> have never been guaranteed.
I just find it sad that "we do not guarantee" translates into "we
actually don't even try". My understanding of your concern is that you
can't rule this breakage out forever, which I can understand.
But if it is possible to avoid breaking compatibility, I believe we
should try this, on a case-by-case base.
We have been pretty good so far (leaving alone the MMC regulator
breakage in v4.15, but A64 support was quite basic before that anyway).
> I'm fine with having it as a U-Boot
> addition, if it's what it takes.
Sounds good to me! Thanks!
I will check what's the easiest path to get the 4.20 DTs into U-Boot,
considering a stopover at the Pinebook DTs, and send patches ASAP.
Cheers,
Andre.
next prev parent reply other threads:[~2018-10-17 16:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 5:09 [U-Boot] [PATCH v2 0/5] Add support for Pinebook Vasily Khoruzhick
2018-10-17 5:09 ` [U-Boot] [PATCH v2 1/5] mmc: sunxi: A64: add support for automatic delay calibration Vasily Khoruzhick
2018-10-18 0:22 ` André Przywara
2018-10-17 5:09 ` [U-Boot] [PATCH v2 2/5] dm: video: bridge: don't fail to activate bridge if reset or sleep GPIO is missing Vasily Khoruzhick
2018-10-18 0:22 ` André Przywara
2018-10-17 5:09 ` [U-Boot] [PATCH v2 3/5] sunxi: DT: A64: update device tree file for Allwinner A64 SoC Vasily Khoruzhick
2018-10-17 15:03 ` Vasily Khoruzhick
2018-10-17 15:13 ` Jernej Škrabec
2018-10-17 15:18 ` Andre Przywara
2018-10-17 15:29 ` Maxime Ripard
2018-10-17 16:54 ` Andre Przywara [this message]
2018-10-17 17:09 ` Vasily Khoruzhick
2018-10-17 17:15 ` Andre Przywara
2018-10-17 15:40 ` Vasily Khoruzhick
2018-10-18 0:21 ` André Przywara
2018-10-17 5:09 ` [U-Boot] [PATCH v2 4/5] sun50i: A64: add support for R_I2C controller Vasily Khoruzhick
2018-10-18 0:22 ` André Przywara
2018-10-17 5:09 ` [U-Boot] [PATCH v2 5/5] sunxi: DT: add support for Pinebook Vasily Khoruzhick
2018-10-17 14:37 ` Maxime Ripard
2018-10-17 15:13 ` Vasily Khoruzhick
2018-10-17 15:22 ` Jernej Škrabec
2018-10-17 15:37 ` Vasily Khoruzhick
2018-10-18 0:23 ` André Przywara
2018-10-18 4:48 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017175419.009550b8@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox