public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] ARM: qemu-arm: define fdt_addr_r
Date: Wed, 24 Oct 2018 13:43:33 +0300	[thread overview]
Message-ID: <20181024134333.2544c4fc@thinkpad> (raw)
In-Reply-To: <20181022044007.11796-4-takahiro.akashi@linaro.org>

Hi Takahiro,

On Mon, 22 Oct 2018 13:40:07 +0900
AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:

> This variable, fdt_addr_t, is missing in the current qemu-arm.h while
> it seems to be mandatory, at least, to run distro_bootcmd as expected.
> So just add its definition. A size of 1MB would be enough.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  include/configs/qemu-arm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/qemu-arm.h b/include/configs/qemu-arm.h
> index 91fb8d47edf8..0e66f946dde5 100644
> --- a/include/configs/qemu-arm.h
> +++ b/include/configs/qemu-arm.h
> @@ -55,6 +55,7 @@
>  	"fdt_high=0xffffffff\0" \
>  	"initrd_high=0xffffffff\0" \
>  	"fdt_addr=0x40000000\0" \
> +	"fdt_addr_r=0x40100000\0" \
>  	"scriptaddr=0x40200000\0" \
>  	"pxefile_addr_r=0x40300000\0" \
>  	"kernel_addr_r=0x40400000\0" \

The same problem as in the previous version still exists; applying
these as-is would regress any boot entries in PXE files that use the
FDTDIR directive since it'd try to load a non-existent .dtb and fail.

We need some way to avoid that; maybe some magic value
(e.g. fdtfile=none) or a separate environment variable or CONFIG_
option.

- Tuomas

      reply	other threads:[~2018-10-24 10:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22  4:40 [U-Boot] [PATCH v2 0/3] efi_loader: improve boot sequence in distro_bootcmd AKASHI Takahiro
2018-10-22  4:40 ` [U-Boot] [PATCH v2 1/3] efi_loader: rework fdt handling in distro boot script AKASHI Takahiro
2018-10-22  7:22   ` AKASHI Takahiro
2018-10-22  7:42     ` Alexander Graf
2018-10-23  2:08       ` AKASHI Takahiro
2018-10-23  7:36         ` Alexander Graf
2018-10-23  8:01           ` AKASHI Takahiro
2018-10-22  4:40 ` [U-Boot] [PATCH v2 2/3] ARM: qemu-arm: rework Kconfig AKASHI Takahiro
2018-10-22  4:40 ` [U-Boot] [PATCH v2 3/3] ARM: qemu-arm: define fdt_addr_r AKASHI Takahiro
2018-10-24 10:43   ` Tuomas Tynkkynen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024134333.2544c4fc@thinkpad \
    --to=tuomas.tynkkynen@iki.fi \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox