public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: lpc32xx mlc: predefine number of NAND chips to support
Date: Mon, 29 Oct 2018 10:29:35 +0100	[thread overview]
Message-ID: <20181029102935.35d6710d@xps13> (raw)
In-Reply-To: <20181019002105.4620-1-vz@mleia.com>

Hi Vladimir,

Vladimir Zapolskiy <vz@mleia.com> wrote on Fri, 19 Oct 2018 03:21:05
+0300:

> Build option CONFIG_SYS_MAX_NAND_CHIPS is used by NXP LPC32xx NAND MLC
> driver only, as a preparation for potential removal or replacement of
> the option the change predefines CONFIG_SYS_MAX_NAND_CHIPS to 1, same
> value is used by the single user Work Microwave Work 92105 board, thus
> it will be safe now to remove the option as a board specific one.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  drivers/mtd/nand/raw/lpc32xx_nand_mlc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c b/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> index 5d4ffea608d9..79d1489dc72c 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_nand_mlc.c
> @@ -82,6 +82,10 @@ struct lpc32xx_nand_mlc_registers {
>  static struct lpc32xx_nand_mlc_registers __iomem *lpc32xx_nand_mlc_registers
>  	= (struct lpc32xx_nand_mlc_registers __iomem *)MLC_NAND_BASE;
>  
> +#if !defined(CONFIG_SYS_MAX_NAND_CHIPS)
> +#define CONFIG_SYS_MAX_NAND_CHIPS	1
> +#endif
> +
>  #define clkdiv(v, w, o) (((1+(clk/v)) & w) << o)
>  
>  /**


If it is safe now, can you also remote the CONFIG_ option now?

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

  reply	other threads:[~2018-10-29  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19  0:21 [U-Boot] [PATCH] mtd: nand: lpc32xx mlc: predefine number of NAND chips to support Vladimir Zapolskiy
2018-10-29  9:29 ` Miquel Raynal [this message]
2018-10-29 16:58   ` Vladimir Zapolskiy
2018-11-17 13:32 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029102935.35d6710d@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox