From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: lpc32xx slc: disable DMA support in SPL builds
Date: Mon, 29 Oct 2018 10:34:10 +0100 [thread overview]
Message-ID: <20181029103410.33bb32e5@xps13> (raw)
In-Reply-To: <20181019002118.4674-1-vz@mleia.com>
Hi Vladimir,
Vladimir Zapolskiy <vz@mleia.com> wrote on Fri, 19 Oct 2018 03:21:18
+0300:
> Testing and analysis shows that at the moment LPC32xx NAND SLC driver
> can not get PL080 DMA backbone support in SPL build, because SPL NAND
> loaders operate with subpage (ECC step to be precisely) reads, and
> this is not supported in the NAND SLC + DMA + hardware ECC calculation
> bundle.
>
> The change removes a cautious build time warning and explicitly
> disables DMA flavour of the driver for SPL builds, to reduce the
> amound of #ifdef sections the code blocks are minimally reorganized.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Could you please split this patch?
The copyright change should be a patch on its own.
The changes in the coding style without functional changes also.
Then you can do your changes about removing DMA support for SPL.
However, on this topic, I'm not sure this is a wise idea. Maybe the SPL
should be fixed so that it can work with DMA?
Thanks,
Miquèl
next prev parent reply other threads:[~2018-10-29 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 0:21 [U-Boot] [PATCH] mtd: nand: lpc32xx slc: disable DMA support in SPL builds Vladimir Zapolskiy
2018-10-29 9:34 ` Miquel Raynal [this message]
2018-10-29 17:09 ` Vladimir Zapolskiy
2018-11-17 13:32 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029103410.33bb32e5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox